Hello,
I don’t have intentions to add a module-info file to logging. I think we should
just go with the Automatic-Module-Header solution.
I started this thread to find out why the Logging repo contains Java 1.3 files
although the build targets Java 1.2. With the latest commons-parent, I get
bu
On 30 October 2017 at 23:09, Stephen Colebourne wrote:
> Does commons-logging need to be a full module with a module-info.java?
> Probably not at this point. Adding Automatic-Module-Name is probably
> sufficient. However, if someone wants to do the work, then adding
> module-info shouldn't be bloc
Does commons-logging need to be a full module with a module-info.java?
Probably not at this point. Adding Automatic-Module-Name is probably
sufficient. However, if someone wants to do the work, then adding
module-info shouldn't be blocked IMO.
I don't believe that module-info.java requires Java 6
Gary,
As you know Log4j has a maven module for Java 9. It contains the
module-info.java file. That module compiles with Java 9 and targets Java 9 as
there isn’t much point targeting anything earlier. That class files produced
are then overlaid on top of the classes produced for Log4j-api, wh
>From a pragmatic POV, the oldest Java byte codes you can get Java 9 to emit
are for Java 1.6. Since we will want, I assume, to produce a module info
class in the jar, we will need to use Java 9 for that (to keep an RM's life
manageable.)
This means to me that we should set the bar at Java 1.6 for
I was trying to follow Stephen's guidance that the build needs Java 9 and
the code can stay at Java 6-8.
Gary
On Oct 28, 2017 10:21, "Ralph Goers" wrote:
> That isn’t strictly true Gary, There are ways to build the module-info
> without upgrading the main code to Java 9. That said, it is a bit
Hello,
maybe we should decide on what we want to achieve here, before I start the
endeavor of creating an RC for such an old component.
My understanding of Logging is, that it is in semi dormant mode. That we don’t
want to add any new features and instead point users to Log4j2. Since Logging
h
That isn’t strictly true Gary, There are ways to build the module-info without
upgrading the main code to Java 9. That said, it is a bit of a hack to do it.
Ralph
> On Oct 28, 2017, at 8:19 AM, Gary Gregory wrote:
>
> Let's update to at least a minimum of Java 6 such that the build can run
> w
Let's update to at least a minimum of Java 6 such that the build can run
with Java 9. Builing with Java 9 will be a requirement to add module info.
Gary
On Oct 28, 2017 01:21, "Benedikt Ritter" wrote:
> Hi all,
>
> After I was able to update the the build to the latest parent POM, I’m
> running
Hi all,
After I was able to update the the build to the latest parent POM, I’m running
into animal sniffer problems. The build is defined to target Java 1.2 but there
are classes which require later JDKs:
- Jdk13LumberjackLogger
- Jdk14Logger
This breaks the build because animal sniffer report
10 matches
Mail list logo
