Re: [LANG] Add Any Checks for Not Checks in StringUtils

2024-06-13 Thread Department 8
No problem this was actually my first time engaging in any Open source contribution, so it was a good way to know what should be done in quality and quantity for any open source contribution, so thanks for helping me learn as well. On Thu, Jun 13, 2024, 19:13 Gary D. Gregory wrote: > On 2024/06/

Re: [LANG] Add Any Checks for Not Checks in StringUtils

2024-06-13 Thread Gary D. Gregory
On 2024/06/13 00:22:13 Department 8 wrote: > I see the point you are making. Thanks for taking the time to review it. And thank you for engaging with us on improving this component! :-) Gary > > On Wed, Jun 12, 2024, 23:30 Gary Gregory wrote: > > > See also my comment in the PR. > > > > Gary

Re: [LANG] Add Any Checks for Not Checks in StringUtils

2024-06-12 Thread Department 8
I see the point you are making. Thanks for taking the time to review it. On Wed, Jun 12, 2024, 23:30 Gary Gregory wrote: > See also my comment in the PR. > > Gary > > On Wed, Jun 12, 2024, 1:22 PM Department 8 > wrote: > > > Haha! It was in fact because of other methods that have simple negatio

Re: [LANG] Add Any Checks for Not Checks in StringUtils

2024-06-12 Thread Gary Gregory
See also my comment in the PR. Gary On Wed, Jun 12, 2024, 1:22 PM Department 8 wrote: > Haha! It was in fact because of other methods that have simple negation > that I thought maybe giving a PR would be Okay :) > > I think that many times, it is the Boolean Logic that may trivial for us, > but

Re: [LANG] Add Any Checks for Not Checks in StringUtils

2024-06-12 Thread Department 8
Haha! It was in fact because of other methods that have simple negation that I thought maybe giving a PR would be Okay :) I think that many times, it is the Boolean Logic that may trivial for us, but for some who may be using them to have a utility methods like isNotBlank aka (!isBlank) maybe help

Re: [LANG] Add Any Checks for Not Checks in StringUtils

2024-06-12 Thread Alex Herbert
On Wed, 12 Jun 2024 at 18:03, Department 8 wrote: > Sorry Alex just now saw your email, before sending out the PR! > > I had done just for isAllEmpty and isAllBlank. > > Can you tell me more on what can be done, when you said the following: > > If you are simply negating the result of another met

Re: [LANG] Add Any Checks for Not Checks in StringUtils

2024-06-12 Thread Department 8
Sorry Alex just now saw your email, before sending out the PR! I had done just for isAllEmpty and isAllBlank. Can you tell me more on what can be done, when you said the following: If you are simply negating the result of another method then this use case may be better served with addition of a

Re: [LANG] Add Any Checks for Not Checks in StringUtils

2024-06-12 Thread Department 8
I just realized the subject name is bad. But here are the two small methods I propose - *isAnyNotBlank* and *isAnyNotEmpty*. Please find the pull request as here: https://github.com/apache/commons-lang/pull/1234 On Wed, 12 Jun 2024 at 21:52, Department 8 wrote: > Hey! > > Recently when using St

Re: [LANG] Add Any Checks for Not Checks in StringUtils

2024-06-12 Thread Alex Herbert
Hi, On Wed, 12 Jun 2024 at 17:23, Department 8 wrote: > Hey! > > Recently when using StringUtils in one of our projects I had felt the > urgent need to have a utility method like => isAnyNotBlank. > > I was able to achieve this using the negation of isAllBlank, so I am > thinking of introducing