Re: [LANG] - suggestions for new Identity Hash code classes

2008-09-16 Thread sebb
On 16/09/2008, Simon Kitching <[EMAIL PROTECTED]> wrote: > sebb schrieb: > > > On 16/09/2008, Jörg Schaible <[EMAIL PROTECTED]> wrote: > > > > > > > sebb wrote: > > > > On 16/09/2008, Simon Kitching <[EMAIL PROTECTED]> wrote: > > > > > > [snip] > > > > > > > > > > > > > > > > > > It's not quite c

Re: [LANG] - suggestions for new Identity Hash code classes

2008-09-16 Thread sebb
On 16/09/2008, sebb <[EMAIL PROTECTED]> wrote: > I think I've found a fix to LANG-459 - which is to borrow some code > from Apache Axis. > > The required code is a single short class - IDKey (e.g. > http://www.jdocs.com/axis/1.4/org/apache/axis/utils/IDKey.html) > > It could be added as a priva

Re: [LANG] - suggestions for new Identity Hash code classes

2008-09-16 Thread Simon Kitching
sebb schrieb: On 16/09/2008, Jörg Schaible <[EMAIL PROTECTED]> wrote: sebb wrote: > On 16/09/2008, Simon Kitching <[EMAIL PROTECTED]> wrote: [snip] It's not quite clear to me why a threadlocal is being used here. I'm >> guessing it is for performance to avoid recreating t

Re: [LANG] - suggestions for new Identity Hash code classes

2008-09-16 Thread sebb
On 16/09/2008, Jörg Schaible <[EMAIL PROTECTED]> wrote: > sebb wrote: > > On 16/09/2008, Simon Kitching <[EMAIL PROTECTED]> wrote: > > [snip] > > >> It's not quite clear to me why a threadlocal is being used here. I'm > >> guessing it is for performance to avoid recreating the HashSet > >> obje

RE: [LANG] - suggestions for new Identity Hash code classes

2008-09-16 Thread Jörg Schaible
sebb wrote: > On 16/09/2008, Simon Kitching <[EMAIL PROTECTED]> wrote: [snip] >> It's not quite clear to me why a threadlocal is being used here. I'm >> guessing it is for performance to avoid recreating the HashSet >> object. > > I don't know for sure, but that is probably the case. > >> Or is

Re: [LANG] - suggestions for new Identity Hash code classes

2008-09-16 Thread sebb
On 16/09/2008, Simon Kitching <[EMAIL PROTECTED]> wrote: > sebb schrieb: > > > On 16/09/2008, Simon Kitching <[EMAIL PROTECTED]> wrote: > > > > > > > One other concern is regarding garbage collection. From a brief look at > the > > > code, this thread-local registry object contains a set of Intege

Re: [LANG] - suggestions for new Identity Hash code classes

2008-09-16 Thread sebb
On 16/09/2008, Jörg Schaible <[EMAIL PROTECTED]> wrote: > Hi Simon, > > Simon Kitching wrote: > [snip] > > > One other concern is regarding garbage collection. From a > > brief look at > > the code, this thread-local registry object contains a set of Integer > > hashcodes. With this change, th

Re: [LANG] - suggestions for new Identity Hash code classes

2008-09-16 Thread Simon Kitching
sebb schrieb: On 16/09/2008, Simon Kitching <[EMAIL PROTECTED]> wrote: One other concern is regarding garbage collection. From a brief look at the code, this thread-local registry object contains a set of Integer hashcodes. With this change, the set will now contain real hard references to

RE: [LANG] - suggestions for new Identity Hash code classes

2008-09-16 Thread Jörg Schaible
sebb wrote: > On 16/09/2008, Simon Kitching <[EMAIL PROTECTED]> wrote: [snip] >> One other concern is regarding garbage collection. From a brief >> look at the code, this thread-local registry object contains a set >> of Integer hashcodes. With this change, the set will now contain >> real hard re

RE: [LANG] - suggestions for new Identity Hash code classes

2008-09-16 Thread Jörg Schaible
Hi Simon, Simon Kitching wrote: [snip] > One other concern is regarding garbage collection. From a > brief look at > the code, this thread-local registry object contains a set of Integer > hashcodes. With this change, the set will now contain real hard > references to objects, preventing them from

Re: [LANG] - suggestions for new Identity Hash code classes

2008-09-16 Thread sebb
On 16/09/2008, Simon Kitching <[EMAIL PROTECTED]> wrote: > sebb schrieb: > > > I think I've found a fix to LANG-459 - which is to borrow some code > > from Apache Axis. > > > > The required code is a single short class - IDKey (e.g. > > > http://www.jdocs.com/axis/1.4/org/apache/axis/utils/IDKey.ht

Re: [LANG] - suggestions for new Identity Hash code classes

2008-09-16 Thread Simon Kitching
sebb schrieb: I think I've found a fix to LANG-459 - which is to borrow some code from Apache Axis. The required code is a single short class - IDKey (e.g. http://www.jdocs.com/axis/1.4/org/apache/axis/utils/IDKey.html) It could be added as a private class of HashCodeBuilder, but it has wider u

RE: [LANG] - suggestions for new Identity Hash code classes

2008-09-16 Thread Jörg Schaible
sebb wrote: > I think I've found a fix to LANG-459 - which is to borrow some code > from Apache Axis. > > The required code is a single short class - IDKey (e.g. > http://www.jdocs.com/axis/1.4/org/apache/axis/utils/IDKey.html) > > It could be added as a private class of HashCodeBuilder, but it

[LANG] - suggestions for new Identity Hash code classes

2008-09-16 Thread sebb
I think I've found a fix to LANG-459 - which is to borrow some code from Apache Axis. The required code is a single short class - IDKey (e.g. http://www.jdocs.com/axis/1.4/org/apache/axis/utils/IDKey.html) It could be added as a private class of HashCodeBuilder, but it has wider use, so should pr