Re: [JEXL] JexlFeatures exposes internal flag representation

2023-10-23 Thread Henri Biestro
Good to know, thanks for pointing this out. Reduced flags public exposure in JEXL per last commit. Henrib - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [JEXL] JexlFeatures exposes internal flag representation

2023-10-22 Thread sebb
There's another reason why using public constants is problematic: The Java compiler inlines constants into the class that uses them. So, if we change a constant and only recompile that class and not the referencing class, we can get inconsistent constant values. This means that changes to public

[JEXL] JexlFeatures exposes internal flag representation

2023-10-21 Thread sebb
A recent change to JexlFeatures made some flag combinations public. Seems to me that this unnecessarily exposes the internal representation, which makes it much harder to change it later. Making constants public can constrain future changes, whereas providing access via methods is easier to mainta