Re: [IO] Improvements to CharSequenceReader

2019-08-10 Thread Rob Spoor
Hi Gary, I just created two PRs. #90 is for the use of getChars only. #91 was built from that one, and adds the sub sequence support. In the latter I have added a test for de-serializing a CharSequenceReader that I serialized before adding any new code, to make sure this still works. Rob O

Re: [IO] Improvements to CharSequenceReader

2019-08-09 Thread Gary Gregory
Hi Rob, Do you plan on creating a PR? Gary On Thu, Aug 1, 2019 at 7:00 AM Rob Spoor wrote: > On 01/08/2019 12:31, Rob Spoor wrote: > > Hi, > > > > CharSequenceReader is great, but I think there can be two improvements: > > > > 1) read(char[], int, int) currently calls read() several times, whi

Re: [IO] Improvements to CharSequenceReader

2019-08-01 Thread Rob Spoor
On 01/08/2019 12:31, Rob Spoor wrote: Hi, CharSequenceReader is great, but I think there can be two improvements: 1) read(char[], int, int) currently calls read() several times, which delegates to charSequence.charAt. That's fine in Java 8 and before, but in Java 9 the internal storage of Str

[IO] Improvements to CharSequenceReader

2019-08-01 Thread Rob Spoor
Hi, CharSequenceReader is great, but I think there can be two improvements: 1) read(char[], int, int) currently calls read() several times, which delegates to charSequence.charAt. That's fine in Java 8 and before, but in Java 9 the internal storage of String, StringBuilder and StringBuffer is