Re: [IMAGING] Constant interfaces vs. constant classes

2015-01-05 Thread Benedikt Ritter
I've created https://issues.apache.org/jira/browse/IMAGING-156 to track this change. 2015-01-04 21:12 GMT+01:00 sebb : > +1 > > On 4 January 2015 at 19:15, Gary Gregory wrote: > > +1: Interfaces should be used to define contracts, not constants. I like > > using classes to define constants. > >

Re: [IMAGING] Constant interfaces vs. constant classes

2015-01-04 Thread sebb
+1 On 4 January 2015 at 19:15, Gary Gregory wrote: > +1: Interfaces should be used to define contracts, not constants. I like > using classes to define constants. > > Gary > > On Sun, Jan 4, 2015 at 1:58 PM, Benedikt Ritter wrote: > >> Hi all, >> >> imaging has a lot of constant interfaces and e

Re: [IMAGING] Constant interfaces vs. constant classes

2015-01-04 Thread Gary Gregory
+1: Interfaces should be used to define contracts, not constants. I like using classes to define constants. Gary On Sun, Jan 4, 2015 at 1:58 PM, Benedikt Ritter wrote: > Hi all, > > imaging has a lot of constant interfaces and even the > org.apache.commons.imaging.formats.tiff.constants.AllTagC

[IMAGING] Constant interfaces vs. constant classes

2015-01-04 Thread Benedikt Ritter
Hi all, imaging has a lot of constant interfaces and even the org.apache.commons.imaging.formats.tiff.constants.AllTagConstants interface which combine several interfaces. I'm in the "no constant interfaces" group. An interface should be used to, well, define an interface. Defining interfaces onl