Re: [Graph] Possible NPE if user requests a vertex that not exists on BaseGraph class

2012-02-15 Thread Simone Tripodi
Hola, yes, I think so, every wrong behavior in the data structure should throw GE, according to what we already agreed on on Graph contract. best, -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On We

Re: [Graph] Possible NPE if user requests a vertex that not exists on BaseGraph class

2012-02-15 Thread Marco Speranza
hi, > I'd recommend to throw the GraphException, as we reported in the javadoc: I was thinking to use the method graph.utils.Assertions.checkArgument, it throws an IllegalArgumentEx, but also GraphExpetion sounds good! one more thing, the method getEdge() creates an instance of VertexPair for

Re: [Graph] Possible NPE if user requests a vertex that not exists on BaseGraph class

2012-02-15 Thread Simone Tripodi
Hola! I'd recommend to throw the GraphException, as we reported in the javadoc: * NOTE: implementors have to take in consideration throwing a {@link GraphException} * if an error occurs while performing that operation. How does it sound? all the best, -Simo http://people.apache.org/~

[Graph] Possible NPE if user requests a vertex that not exists on BaseGraph class

2012-02-15 Thread Marco Speranza
Hi all guys, I notice that the methods "getConnectedVertices( V v )" and "getEdge( V source, V target )" into the class BaseGraph are not protect if a user passes a vertex that not exists. Moreover in the first case the system throws a NPE and in the second case the system accepts the argument bu