[GitHub] commons-lang pull request: Reimplemented normalize space

2014-08-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [GitHub] commons-lang pull request: Reimplemented normalize space

2014-06-20 Thread Anshul Zunke
Hi I have some doubt about your patch. 1. If we consider that WHITESPACE_PATTERN will be compiled only once during the class load since its a static variable private static final Pattern WHITESPACE_PATTERN = Pattern.compile("(?: |\\u00A0|\\s|[\\s&&[^ ]])\\s*"); Then i doubt the code will tak

[GitHub] commons-lang pull request: Reimplemented normalize space

2014-06-20 Thread librucha
GitHub user librucha opened a pull request: https://github.com/apache/commons-lang/pull/27 Reimplemented normalize space Hi. I reimplemented normalize space method of String utils, because regexp is much more rich operation than array traversing and I use this normalization oft