[GitHub] commons-fileupload pull request #17: Move static analysis plugins from repor...

2018-05-21 Thread krichter722
GitHub user krichter722 opened a pull request: https://github.com/apache/commons-fileupload/pull/17 Move static analysis plugins from reporting to build Moving the static code analysis plugins maven-checkstyle-plugin and maven-pmd-plugin from the reporting to the build section an

[GitHub] commons-fileupload pull request #16: Use Apache Commons I/O in tests

2018-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-fileupload/pull/16 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.o

[GitHub] commons-fileupload pull request #16: Use Apache Commons I/O in tests

2018-05-21 Thread krichter722
GitHub user krichter722 opened a pull request: https://github.com/apache/commons-fileupload/pull/16 Use Apache Commons I/O in tests Replace File.delete and File.mkdir with Apache Commons I/O's FileUtils equivalent which throw IOException instead of returning false which reduc

[GitHub] commons-fileupload pull request #15: pom.xml: Remove tab characters

2018-05-21 Thread krichter722
Github user krichter722 closed the pull request at: https://github.com/apache/commons-fileupload/pull/15 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apa

[GitHub] commons-fileupload pull request #15: pom.xml: Remove tab characters

2018-05-21 Thread krichter722
GitHub user krichter722 opened a pull request: https://github.com/apache/commons-fileupload/pull/15 pom.xml: Remove tab characters pom.xml contains a mixture of spaces and tab characters in order to indent markup which is confusing. Spaces should be used instead where applica

[GitHub] commons-fileupload pull request #14: Add missing @Override annotations

2018-05-21 Thread krichter722
Github user krichter722 closed the pull request at: https://github.com/apache/commons-fileupload/pull/14 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apa

[GitHub] commons-fileupload pull request #14: Add missing @Override annotations

2018-05-20 Thread krichter722
GitHub user krichter722 opened a pull request: https://github.com/apache/commons-fileupload/pull/14 Add missing @Override annotations @Override annotations help to detect architectural errors and respond quicker to method changes. Unclear why the checkstyle configuration whic

[GitHub] commons-fileupload pull request #13: FileItem.java: remove throwing of Excep...

2018-05-20 Thread krichter722
GitHub user krichter722 opened a pull request: https://github.com/apache/commons-fileupload/pull/13 FileItem.java: remove throwing of Exception Indicating that an interface method throws Exception is overly broad and hides design issues after inheritance changes. You can merge t

[GitHub] commons-fileupload pull request #:

2017-11-24 Thread fangwentong
Github user fangwentong commented on the pull request: https://github.com/apache/commons-fileupload/commit/180f6138b185a03ae1ee154b8048d67cf23af181#commitcomment-25838427 In src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java: In src/main/java/org/apache/commons/file

[GitHub] commons-fileupload pull request #12: FILEUPLOAD-288: detect file only if the...

2017-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-fileupload/pull/12 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.o

[GitHub] commons-fileupload pull request #12: FILEUPLOAD-288: detect file only if the...

2017-11-22 Thread fangwentong
GitHub user fangwentong opened a pull request: https://github.com/apache/commons-fileupload/pull/12 FILEUPLOAD-288: detect file only if the file written to disk. see https://issues.apache.org/jira/browse/FILEUPLOAD-288 You can merge this pull request into a Git repository by running

[GitHub] commons-fileupload pull request #11: travis: fix buffer overflow in Java_jav...

2017-10-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-fileupload/pull/11 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.o

[GitHub] commons-fileupload pull request #9: Msamery commons fileupload 1.3.2 patch 1

2017-10-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-fileupload/pull/9 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.or

[GitHub] commons-fileupload pull request #11: travis: fix buffer overflow in Java_jav...

2017-10-08 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-fileupload/pull/11 travis: fix buffer overflow in Java_java_net_Inet4AddressImpl_getLoca… …lHostName of OpenJDK6 and OpenJDK7 when using precise distribution To fix this use the current

[GitHub] commons-fileupload pull request #10: FILEUPLOAD-286: allow default charset t...

2017-10-06 Thread maxxedev
Github user maxxedev closed the pull request at: https://github.com/apache/commons-fileupload/pull/10 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache

[GitHub] commons-fileupload pull request #10: FILEUPLOAD-286: allow default charset t...

2017-10-06 Thread maxxedev
GitHub user maxxedev opened a pull request: https://github.com/apache/commons-fileupload/pull/10 FILEUPLOAD-286: allow default charset to be overridden. useful in cases where form-data is utf-8 encoded but not encoding is not explicitly specified You can merge this pull request

[GitHub] commons-fileupload pull request #9: Msamery commons fileupload 1.3.2 patch 1

2017-08-08 Thread MSAmery
GitHub user MSAmery opened a pull request: https://github.com/apache/commons-fileupload/pull/9 Msamery commons fileupload 1.3.2 patch 1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSAmery/commons-fileupload MSAmery-commons-f

[GitHub] commons-fileupload pull request #:

2017-08-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-fileupload/commit/86a79bceac4a267819de986ca814f11b48d81da3#commitcomment-23494230 In src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java: In src/test/java/org/apache/comm

[GitHub] commons-fileupload pull request #:

2017-08-04 Thread kinow
Github user kinow commented on the pull request: https://github.com/apache/commons-fileupload/commit/86a79bceac4a267819de986ca814f11b48d81da3#commitcomment-23490295 In src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java: In src/test/java/org/apache/commons/fileupl

[GitHub] commons-fileupload pull request #:

2017-08-04 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-fileupload/commit/86a79bceac4a267819de986ca814f11b48d81da3#commitcomment-23482473 In src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java: In src/test/java/org/apache/comm

[GitHub] commons-fileupload pull request #8: FILEUPLOAD-283: add tests for the portle...

2017-06-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-fileupload/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] commons-fileupload pull request #1: Commons fileupload headerfix

2017-06-22 Thread developerSid
Github user developerSid closed the pull request at: https://github.com/apache/commons-fileupload/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] commons-fileupload pull request #8: FILEUPLOAD-283: add tests for the portle...

2017-06-16 Thread kinow
GitHub user kinow opened a pull request: https://github.com/apache/commons-fileupload/pull/8 FILEUPLOAD-283: add tests for the portlet package Initial tests for the portlet package. I believe there have been updates to the portlet specification(s) that have not been applied to Commo

[GitHub] commons-fileupload pull request #7: FILEUPLOAD-238: add tests for the portle...

2017-06-16 Thread kinow
Github user kinow closed the pull request at: https://github.com/apache/commons-fileupload/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] commons-fileupload pull request #7: FILEUPLOAD-238: add tests for the portle...

2017-06-16 Thread kinow
GitHub user kinow opened a pull request: https://github.com/apache/commons-fileupload/pull/7 FILEUPLOAD-238: add tests for the portlet package Initial tests for the portlet package. I believe there have been updates to the portlet specification(s) that have not been applied to Commo

[GitHub] commons-fileupload pull request #:

2017-06-15 Thread kinow
Github user kinow commented on the pull request: https://github.com/apache/commons-fileupload/commit/94e5e1a77e4319c98dea22c051e19c1e57c58c00#commitcomment-22573680 :clap: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] commons-fileupload pull request #5: Update DiskFileItem.java: Avoiding NPE w...

2017-05-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-fileupload/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] commons-fileupload pull request #4: FILEUPLOAD-256 Added null pointer handli...

2017-05-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-fileupload/pull/4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] commons-fileupload pull request #3: Eliminate HttpServletRequest#getContentL...

2017-05-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-fileupload/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] commons-fileupload pull request #2: Null content-length headers parsing is r...

2017-05-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-fileupload/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] commons-fileupload pull request #6: improve GC by avoiding FileInput/Output-...

2017-05-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-fileupload/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] commons-fileupload pull request #6: improve GC by avoiding FileInput/Output-...

2017-04-18 Thread alexander-riss
GitHub user alexander-riss opened a pull request: https://github.com/apache/commons-fileupload/pull/6 improve GC by avoiding FileInput/Output-Streams bump compiler target from 1.5 to 1.7 see: https://bugs.openjdk.java.net/browse/JDK-8080225 You can merge this pull request

[GitHub] commons-fileupload pull request #5: Update DiskFileItem.java: Avoiding NPE w...

2016-11-25 Thread OleHornischer
GitHub user OleHornischer opened a pull request: https://github.com/apache/commons-fileupload/pull/5 Update DiskFileItem.java: Avoiding NPE when not explicitely initializ… …ing the outputstream When accessing e.g. getSize() on a DiskFileItem before having called getOutp