[GitHub] commons-compress issue #16: Don't duplicate count() functionality.

2017-02-04 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/commons-compress/pull/16 True, a unit-test wouldn't hurt. I'm afraid I can't close the PR myself. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] commons-compress issue #16: Don't duplicate count() functionality.

2017-02-04 Thread thomasmey
Github user thomasmey commented on the issue: https://github.com/apache/commons-compress/pull/16 Oops. True, my mistake. Maybe we should cover this with a unit test... Sorry for the fuss. --- If your project is set up for it, you can reply to this email and have your

[GitHub] commons-compress issue #16: Don't duplicate count() functionality.

2017-02-04 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/commons-compress/pull/16 Hmm, the no-arg `read` returns the byte read. So when reading an `'A'` your code would count 65 bytes rather than 1, wouldn't it? --- If your project is set up for it, you can reply to this

[GitHub] commons-compress issue #16: Don't duplicate count() functionality.

2017-01-27 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-compress/pull/16 [![Coverage Status](https://coveralls.io/builds/9882175/badge)](https://coveralls.io/builds/9882175) Coverage increased (+0.2%) to 84.291% when pulling **f71a4cd326eff69b42ed