Re: [CHAIN] Thoughts about o.a.c.chain2.Chain, o.a.c.chain2.Command and the base classes

Hi Elijah, The ‘Continue’ and ‘Completed’ values look very similar to me, especially in Unit tests. I suggest naming the two states: - Continue - Finished >With regards to an enum for status, wouldn't it be better to use a class so >that consumers could subclass it and add their own states if need

Re: [CHAIN] Thoughts about o.a.c.chain2.Chain, o.a.c.chain2.Command and the base classes

+1 to everything. With regards to an enum for status, wouldn't it be better to use a class so that consumers could subclass it and add their own states if needed? Thanks, -Elijah On Sat, Jun 22, 2013 at 4:30 AM, Benedikt Ritter wrote: > > Am 22.06.2013 um 12:57 schrieb Simone Tripodi : > > > H

Re: [CHAIN] Thoughts about o.a.c.chain2.Chain, o.a.c.chain2.Command and the base classes

Am 22.06.2013 um 12:57 schrieb Simone Tripodi : > Hi Jonas, > >> >> I will provide a patch for >> CHAIN-98tomorow. The >> patch will only cover the refactoring of CONTINUE and >> COMPLETED processing results. >> > > nice to read that, looking fo

Re: [CHAIN] Thoughts about o.a.c.chain2.Chain, o.a.c.chain2.Command and the base classes

Hi Jonas, > > I will provide a patch for > CHAIN-98tomorow. The > patch will only cover the refactoring of CONTINUE and > COMPLETED processing results. > nice to read that, looking forward to the patch! :) > But, I do not understand how exceptions

Re: [CHAIN] Thoughts about o.a.c.chain2.Chain, o.a.c.chain2.Command and the base classes

Hi Simone, more meat as I expected, thats for sure. I will provide a patch for CHAIN-98tomorow. The patch will only cover the refactoring of CONTINUE and COMPLETED processing results. But, I do not understand how exceptions should be handled in thi

Re: [CHAIN] Thoughts about o.a.c.chain2.Chain, o.a.c.chain2.Command and the base classes

> I'm not sure if we need ABORTED. What is the difference between COMPLETE > and ABORTED from the PoV of the Chain? Chain defines an algorithm for > processing and I currently don't see how ABORTED fits in there. > OTOH I see some potential here: * COMPLETE: all chain commands have completed the

Re: [CHAIN] Thoughts about o.a.c.chain2.Chain, o.a.c.chain2.Command and the base classes

2013/6/21 Simone Tripodi > Thanks Jonas, > > would you submit a patch for that? TIA! > > -Simo > > http://people.apache.org/~simonetripodi/ > http://twitter.com/simonetripodi > > > On Thu, Jun 20, 2013 at 11:09 PM, Jonas Sprenger > wrote: > > Hi guys, > > > > so we talk about an enum 'PROCESSIN

Re: [CHAIN] Thoughts about o.a.c.chain2.Chain, o.a.c.chain2.Command and the base classes

Thanks Jonas, would you submit a patch for that? TIA! -Simo http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi On Thu, Jun 20, 2013 at 11:09 PM, Jonas Sprenger wrote: > Hi guys, > > so we talk about an enum 'PROCESSING' providing at least 3 states? > > - CONTINUE > - C

Re: [CHAIN] Thoughts about o.a.c.chain2.Chain, o.a.c.chain2.Command and the base classes

Hi guys, so we talk about an enum 'PROCESSING' providing at least 3 states? - CONTINUE - COMPLETE - ABORTED Ticket CHAIN-98 has been created to cover this task. regards, Jonas 2013/6/20 Simone Tripodi > Hallo Bene, > > > * JavaDoc of Command

Re: [CHAIN] Thoughts about o.a.c.chain2.Chain, o.a.c.chain2.Command and the base classes

Hallo Bene, > * JavaDoc of Command says that commands have to be designed in a > thread-safe manner, yet all the base implementations are not thread safe! I > have created CHAIN-96 [1] for this, because this definitely has to be fixed > before 2.0 +1 > * The same is true for o.a.c.chain2.Chain

[CHAIN] Thoughts about o.a.c.chain2.Chain, o.a.c.chain2.Command and the base classes

Hi guys, I had a look at the command interface and it's base classes yesterday, and I think there is some work to do :) Here are the points I found: * JavaDoc of Command says that commands have to be designed in a thread-safe manner, yet all the base implementations are not thread safe! I have c