Re: [Bag] random pick

2013-03-19 Thread Thomas Neidhart
On 03/19/2013 10:38 PM, Othmen Tiliouine wrote: > should i close the issue > https://issues.apache.org/jira/browse/COLLECTIONS-448 ? no, please leave it like this, the proposal is good, but it will probably take some time to get processed. Thomas -

Re: [Bag] random pick

2013-03-19 Thread Othmen Tiliouine
should i close the issue https://issues.apache.org/jira/browse/COLLECTIONS-448 ?

Re: [Bag] random pick

2013-03-17 Thread Othmen Tiliouine
yes with auxiliary array it is a good solution too

Re: [Bag] random pick

2013-03-17 Thread Othmen Tiliouine
2013/3/17 Ted Dunning > Finally, the names should not consist of combinations of "pick" and > "remit". The correct English terms are "sample" and "replacement". > I suspected that the name was not good, it is because my English is poor also, it was perhaps unnecessary to consider two methods 'p

Re: [Bag] random pick

2013-03-17 Thread Thomas Neidhart
On 03/17/2013 03:02 AM, Ted Dunning wrote: > I think that this implementation is a problem. > > Bag implementations tend to fall into different categories, according to > whether they provide unit (or log) time random access, random deletion and > ordered traversal. Most implementations don't pro

Re: [Bag] random pick

2013-03-16 Thread Ted Dunning
I think that this implementation is a problem. Bag implementations tend to fall into different categories, according to whether they provide unit (or log) time random access, random deletion and ordered traversal. Most implementations don't provide unit time for all operations. I think that your

Re: [Bag] random pick

2013-03-16 Thread Othmen Tiliouine
This is an example of use of pick from Bag https://github.com/influence160/flera see the classes https://github.com/influence160/flera/blob/master/flera-core/src/main/java/com/otiliouine/flera/SuccessionBasedWordGenerator.javaand https://github.com/influence160/flera/blob/master/flera-core/src/ma

Re: [Bag] random pick

2013-03-13 Thread Othmen Tiliouine
I remplaced the patch 2013/3/13 Ted Dunning > You seem to have reformatted the entire file. This makes it nearly > impossible to review your suggested change. > > Can you make a diff that doesn't involve changing every line in the file? > > On Tue, Mar 12, 2013 at 3:48 PM, Othmen Tiliouine < >

Re: [Bag] random pick

2013-03-12 Thread Ted Dunning
You seem to have reformatted the entire file. This makes it nearly impossible to review your suggested change. Can you make a diff that doesn't involve changing every line in the file? On Tue, Mar 12, 2013 at 3:48 PM, Othmen Tiliouine < tiliouine.oth...@gmail.com> wrote: > i puted the suggestio

Re: [Bag] random pick

2013-03-12 Thread Othmen Tiliouine
i puted the suggestion and attached the patch https://issues.apache.org/jira/browse/COLLECTIONS-448 2013/3/12 Thomas Neidhart > On 03/12/2013 08:58 AM, Othmen Tiliouine wrote: > > Thank you Ted, > > > > I understand from your mail that there is no particular reason that makes > > that the inter

Re: [Bag] random pick

2013-03-12 Thread Thomas Neidhart
On 03/12/2013 08:58 AM, Othmen Tiliouine wrote: > Thank you Ted, > > I understand from your mail that there is no particular reason that makes > that the interface Bag no contains these methods and that this subject has > never been discussed in the mailing list. > > I'll see if I can create this

Re: [Bag] random pick

2013-03-12 Thread Othmen Tiliouine
Thank you Ted, I understand from your mail that there is no particular reason that makes that the interface Bag no contains these methods and that this subject has never been discussed in the mailing list. I'll see if I can create this patch this weekend, but i want to know, what do you think wha

Re: [Bag] random pick

2013-03-11 Thread Ted Dunning
Othmen, The common way to contribute code is to file a bug report/enhancement request at the correct commons component: https://issues.apache.org/jira/secure/BrowseProjects.jspa#10260 My guess is that you want collections which is at https://issues.apache.org/jira/browse/COLLECTIONS Then you s