[GitHub] commons-cli pull request #12: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-06-13 Thread schaumb
Github user schaumb commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/12#discussion_r121654518 --- Diff: src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java --- @@ -159,13 +161,15 @@ public void testURLPattern() throws Exception

[GitHub] commons-cli pull request #12: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-06-13 Thread schaumb
Github user schaumb commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/12#discussion_r121654518 --- Diff: src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java --- @@ -159,13 +161,15 @@ public void testURLPattern() throws Exception

[GitHub] commons-cli pull request #12: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-06-12 Thread schaumb
Github user schaumb commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/12#discussion_r121406356 --- Diff: src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java --- @@ -159,13 +161,12 @@ public void testURLPattern() throws Exception

[GitHub] commons-cli pull request #12: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-06-12 Thread schaumb
Github user schaumb commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/12#discussion_r121406356 --- Diff: src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java --- @@ -159,13 +161,12 @@ public void testURLPattern() throws Exception

[GitHub] commons-cli pull request #12: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-06-09 Thread schaumb
GitHub user schaumb opened a pull request: https://github.com/apache/commons-cli/pull/12 [CLI-274] implement EXISTING_FILE_VALUE type handler when the user pass option type FileInputStream.class, I think the expected behavior for the return value is the same type, which the user

[GitHub] commons-cli pull request #10: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-04-17 Thread schaumb
GitHub user schaumb opened a pull request: https://github.com/apache/commons-cli/pull/10 [CLI-274] implement EXISTING_FILE_VALUE type handler when the user pass option type FileInputStream.class, I think the expected behavior for the return value is the same type, which the user