[GitHub] commons-fileupload issue #13: FileItem.java: remove throwing of Exception

2018-05-22 Thread jochenw
Github user jochenw commented on the issue: https://github.com/apache/commons-fileupload/pull/13 I agree with Garys concerns (in particular, because I know how widely spread fileupload is, and how difficult it can be to replace the containers version with your own), so won't c

[GitHub] commons-fileupload issue #12: FILEUPLOAD-288: detect file only if the file w...

2017-11-23 Thread jochenw
Github user jochenw commented on the issue: https://github.com/apache/commons-fileupload/pull/12 Applied to master, and b1_3 branches, thank you! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For

[GitHub] commons-fileupload issue #11: travis: fix buffer overflow in Java_java_net_I...

2017-10-08 Thread jochenw
Github user jochenw commented on the issue: https://github.com/apache/commons-fileupload/pull/11 Applied, thank you. Pascal, I'd be interested to know your email address, so that I can add it to changes.xml, and pom.xml/contributors. Please contact me at joc...@apach

[GitHub] commons-fileupload issue #10: FILEUPLOAD-286: allow default charset to be ov...

2017-10-06 Thread jochenw
Github user jochenw commented on the issue: https://github.com/apache/commons-fileupload/pull/10 Applied, thank you! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail

[GitHub] commons-fileupload issue #10: FILEUPLOAD-286: allow default charset to be ov...

2017-10-06 Thread jochenw
Github user jochenw commented on the issue: https://github.com/apache/commons-fileupload/pull/10 Applied. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h

[GitHub] commons-fileupload issue #1: Commons fileupload headerfix

2017-06-18 Thread jochenw
Github user jochenw commented on the issue: https://github.com/apache/commons-fileupload/pull/1 On another issue: Please remove .classpath, and .project from the pull request. These are IDE specific, thus not supposed to live in an Apache project. --- If your project is set up for

[GitHub] commons-fileupload issue #1: Commons fileupload headerfix

2017-06-18 Thread jochenw
Github user jochenw commented on the issue: https://github.com/apache/commons-fileupload/pull/1 Honestly: 88 files changed for one pull request? No chance to get that pulled in. Try to split your changes into smaller change sets. --- If your project is set up for it, you can reply

[GitHub] commons-fileupload issue #7: FILEUPLOAD-238: add tests for the portlet packa...

2017-06-18 Thread jochenw
Github user jochenw commented on the issue: https://github.com/apache/commons-fileupload/pull/7 Bruno, you are a Commons PMC member. Why use a Github pull request, and not just do a commit? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] commons-fileupload issue #6: improve GC by avoiding FileInput/Output-Streams

2017-04-28 Thread jochenw
Github user jochenw commented on the issue: https://github.com/apache/commons-fileupload/pull/6 @ecki Given a reasonable value for sizeThreshold, I'd expect that only very few files are actually being created (say one per request, which is the actual uploaded file), so I wou

[GitHub] commons-fileupload issue #6: improve GC by avoiding FileInput/Output-Streams

2017-04-27 Thread jochenw
Github user jochenw commented on the issue: https://github.com/apache/commons-fileupload/pull/6 @jvz I don't see anyone passing along any money. This is true open source software. We're doing, what we consider to be best for our users in general. @alexander-riss P

[GitHub] commons-fileupload issue #6: improve GC by avoiding FileInput/Output-Streams

2017-04-26 Thread jochenw
Github user jochenw commented on the issue: https://github.com/apache/commons-fileupload/pull/6 As far as I can tell, requiring 1.7 is still no option, because Fileupload is used in basically every application container, that I am aware of, and there are lots of them out in the wild