Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/85#discussion_r202562835
--- Diff:
src/main/java/org/apache/commons/text/similarity/LevenshteinDistance.java ---
@@ -270,12 +270,6 @@ private static int limitedCompare
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/83
Looks good to me. Many thanks for the contribution.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/73
This feels like it should come in before I stage `commons-test-1.2`.
Thoughts?
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/71
Agreed.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/68
Do we want it to be off by default?
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/68
Seems reasonable to me.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/62
@britter, @PascalSchumacher, @garydgregory - thoughts?
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/64
@arunvinudss - would you vote for removing it if we were to roll a, very
hypothetical, 2.0 right now? If so, then I'd say we have our dec
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/62
As I'm pulling this in this crosses my mind:
Wait I'm curious here. Weren't folks leaning towards keeping
`RandomStringUtils` in `[lang]`?
The thread in quest
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/62
Should be able to look again today.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/62#discussion_r140835603
--- Diff: src/main/java/org/apache/commons/text/RandomStringGenerator.java
---
@@ -324,6 +324,40 @@ public Builder withinRange(final int
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/16
Oh pardon. I misread. Iâll re-run through it.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/16
Oh pardon. I misread. Iâll re-run through it.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/62
Sure I'll get to this next.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional comman
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/63
That last build failure wasn't on youjust fixed it in the master branch.
---
-
To unsubscribe, e-mail: dev-uns
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/63#discussion_r140545049
--- Diff: src/main/java/org/apache/commons/text/WordUtils.java ---
@@ -614,10 +614,7 @@ public static String swapCase(final String str
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/55
Pardon...I don't see why this would necessitate a 2.X. Let me re-read.
---
-
To unsubscribe, e-mail: dev-uns
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/55
Are we ready to do a change that would necessitate a 2.X?
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/61#discussion_r130979086
--- Diff: pom.xml ---
@@ -171,6 +171,7 @@
src/site/resources/download_lang.cgi
src/test/resources
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/61#discussion_r130977723
--- Diff: pom.xml ---
@@ -171,6 +171,7 @@
src/site/resources/download_lang.cgi
src/test/resources
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/61
Personally I'm a +0 to +1 on this, but @PascalSchumacher has a very valid
point. I try to subscribe to the thought that there should be a high bar to
sacrificing simplicity. So, with th
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/61
I'll get to this soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/57
Will get to this today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/15
Agreed, pardon my misread. Pulling this in now...only considering
documentation on partial matching.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/15
Agreed, pardon my misread. Pulling this in now...only considering
documentation on partial matching.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/15
Upon reading [CLI-216](https://issues.apache.org/jira/browse/CLI-216) and
[CLI-217](https://issues.apache.org/jira/browse/CLI-217), this pull request
looks like it resolves CLI-216 and not CLI
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/15
Upon reading [CLI-216](https://issues.apache.org/jira/browse/CLI-216) and
[CLI-217](https://issues.apache.org/jira/browse/CLI-217), this pull request
looks like it resolves CLI-216 and not CLI
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/15
Working on this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/15
Working on this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/59
Get a load of this:
https://github.com/jacoco/jacoco/blob/master/.travis.sh
https://github.com/jacoco/jacoco/blob/master/.travis.yml
---
If your project is set up for it, you can reply
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/15
I'll try to get to it today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/15
I'll try to get to it today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user chtompki commented on the issue:
https://github.com/apache/commons-collections/pull/9
Ok no stress. I'll try to see what I can do with it. Cheers, -Rob.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/57
This all opens the question about going `2.x`. I think we have a couple of
things that would warrant a 2.x move. Do we want to attempt that in the fall,
or is it still too premature?
---
If
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/49
Cool. Will look at this in just a bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-collections/pull/24#discussion_r127966801
--- Diff:
src/test/java/org/apache/commons/collections4/iterators/CollatingIteratorTest.java
---
@@ -16,12 +16,14 @@
*/
package
Github user chtompki commented on the issue:
https://github.com/apache/commons-collections/pull/5
@huseyincelik - Do you mind rebasing this work onto the `master` branch and
opening a new pull request?
---
If your project is set up for it, you can reply to this email and have your
Github user chtompki commented on the issue:
https://github.com/apache/commons-collections/pull/9
@gonmarques - Do you mind rebasing this work onto the `master` branch and
opening a new pull request?
---
If your project is set up for it, you can reply to this email and have your
Github user chtompki commented on the issue:
https://github.com/apache/commons-collections/pull/10
@AndersDJohnson - Do you mind rebasing this work on the `master` branch and
opening a new pull request?
---
If your project is set up for it, you can reply to this email and have your
Github user chtompki commented on the issue:
https://github.com/apache/commons-collections/pull/13
@kaching88 - Do you mind rebasing to the `master` branch and re-opening
this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chtompki commented on the issue:
https://github.com/apache/commons-collections/pull/15
@lamrongol - Do you mind rebasing to the `master` branch, and re-opening
this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chtompki commented on the issue:
https://github.com/apache/commons-collections/pull/18
@marko-bekhta - Do you mind rebasing to the `master` branch, and re-opening
this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user chtompki commented on the issue:
https://github.com/apache/commons-collections/pull/19
@Xaerxess - As posted in the [Jira
Issue](https://issues.apache.org/jira/browse/COLLECTIONS-575), do you mind
rebasing to master and re-opening this pull request?
---
If your project
Github user chtompki commented on the issue:
https://github.com/apache/commons-collections/pull/21
@mureinik - Do you mind rebasing to master and re-opening this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user chtompki commented on the issue:
https://github.com/apache/commons-collections/pull/22
@jonasholtkamp - Do you mind rebasing to master and re-opening this pull
request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user chtompki commented on the issue:
https://github.com/apache/commons-collections/pull/3
@geoffschoeman - Do you mind rebasing to master and re-opening this pull
request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user chtompki commented on the issue:
https://github.com/apache/commons-collections/pull/12
Do you mind rebasing to master and re-opening this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chtompki commented on the issue:
https://github.com/apache/commons-collections/pull/24
Actually that's not true today. It's a side effect of my moving collections
to git, but I will look at this and try to pull it in tomorrow morning (UTC-4).
---
If your proj
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/15
Looking at
[CLI-217.patch](https://issues.apache.org/jira/secure/attachment/12568952/CLI-217.patch),
I was wondering if we shouldn't also include changes to `PosixParser`? The
changes wou
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/15
Looking at
[CLI-217.patch](https://issues.apache.org/jira/secure/attachment/12568952/CLI-217.patch),
I was wondering if we shouldn't also include changes to `PosixParser`? The
changes wou
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/15
Yes aside from the `.gitignore` changes, this all looks quite reasonable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/15
Yes aside from the `.gitignore` changes, this all looks quite reasonable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/55
@jbduncan has a point here, but the code here does conform to the style of
the existing code. So, I'd lean more towards the changes @ameyjadiye is
proposing mainly because to re-work the
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/55
Sure...I'll try to look at this in the coming day or so.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/48
Should we add to `public static boolean isDelimiter(final char ch, final
char[] delimiters)` or `isDelimiter` generally, documentation stating that if
an empty array is passed in we always
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-cli/pull/15#discussion_r125656068
--- Diff: .gitignore ---
@@ -1,5 +1,4 @@
-###
https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-cli/pull/15#discussion_r125656068
--- Diff: .gitignore ---
@@ -1,5 +1,4 @@
-###
https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-cli/pull/15#discussion_r125655784
--- Diff: .gitignore ---
@@ -1,5 +1,4 @@
-###
https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-cli/pull/15#discussion_r125655784
--- Diff: .gitignore ---
@@ -1,5 +1,4 @@
-###
https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-cli/pull/15#discussion_r125636671
--- Diff: .gitignore ---
@@ -1,5 +1,4 @@
-###
https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-cli/pull/15#discussion_r125636671
--- Diff: .gitignore ---
@@ -1,5 +1,4 @@
-###
https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/52
Thanks Amey.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/52
Agreed with Pascal here, just for semantics on commit history.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/14
No worries at all. While here, what are your thoughts about that scenario?
To me it seems odd if you concatenated a flag with the value it represents.
Clearly Java delimits arguments passed
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/14
No worries at all. While here, what are your thoughts about that scenario?
To me it seems odd if you concatenated a flag with the value it represents.
Clearly Java delimits arguments passed
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/46
Will try to get to this today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/14
My impression base on my reading of the
[CLI-260](https://issues.apache.org/jira/browse/CLI-260) is that from this code:
```java
private DefaultParser parser;
private
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/14
My impression base on my reading of the
[CLI-260](https://issues.apache.org/jira/browse/CLI-260) is that from this code:
```java
private DefaultParser parser;
private
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/14
I see you got it sorted. I'll give this a look in the morning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user chtompki commented on the issue:
https://github.com/apache/commons-cli/pull/14
I see you got it sorted. I'll give this a look in the morning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/45
I believe the reason that we're getting a "success" to be the fact that the
`docker` command exits with a 0. So might we want to do a `{docker run -v
`pwd`:/work library/ibm
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/45
Hm. I'll give this a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/46
Regarding the `WordUtils.capitalizeFully`, let's open that discussion up in
a new Jira. I'll do that now. I think those questions are quite valid.
---
If your project is set up f
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121374008
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121376797
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121380327
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121374329
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121380270
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121378617
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121376091
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121376021
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/47
I see no reason to not pull this in. Thanks for the contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/45#discussion_r121372102
--- Diff: .travis.yml ---
@@ -21,8 +21,15 @@ jdk:
- oraclejdk7
- oraclejdk8
+services:
+ - docker
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/42
Will look over this again tomorrow early.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/46
Will look this over in the morning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/45
Agreed. Will pull this in tonight or in the morning (UTC-4)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/47
Cool. I'll get to this point n the morning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/45#discussion_r121162806
--- Diff: pom.xml ---
@@ -150,7 +150,7 @@
-clean test apache-rat:check clirr:check checkstyle:check
findbugs:check
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/45#discussion_r121162871
--- Diff: .travis.yml ---
@@ -21,8 +21,15 @@ jdk:
- oraclejdk7
- oraclejdk8
+services:
+ - docker
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/45#discussion_r121162778
--- Diff: .travis.yml ---
@@ -21,8 +21,15 @@ jdk:
- oraclejdk7
- oraclejdk8
+services:
+ - docker
Github user chtompki commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/45#discussion_r121162518
--- Diff: .travis.yml ---
@@ -21,8 +21,15 @@ jdk:
- oraclejdk7
- oraclejdk8
+services:
+ - docker
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/44
@britter - I would have to test it out, but fair point.
It feels like we should always maintain source and binary backwards
compatibility for minor version updates. But, if the policy
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/44
@britter if I declare a class
```java
package com.rt;
import org.apache.commons.text.StrLookup;
public class TextTester extends StrLookup {
public String
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/44
The change is generally all right with me, but we can't release this until
a 2.X release though because of signature changes.
---
If your project is set up for it, you can reply to this
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/44
Would this imply a 2.0 release because of BC compatibility?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user chtompki opened a pull request:
https://github.com/apache/commons-rng/pull/2
RNG-11: refactor such that coveralls uses jacoco instead of cobertura
Another PR for: https://issues.apache.org/jira/browse/RNG-11
You can merge this pull request into a Git repository by
GitHub user chtompki opened a pull request:
https://github.com/apache/commons-rng/pull/1
RNG-11: adding .travis.yml
This resolves https://issues.apache.org/jira/browse/RNG-11
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
97 matches
Mail list logo
