Re: [pool] POOL-272: per-key numTestsPerEvictionRun

2014-09-15 Thread Michael Berman
gt; On 9/11/14 11:39 AM, Phil Steitz wrote: > > On 9/11/14 8:55 AM, Phil Steitz wrote: > >> On 9/9/14 11:38 AM, Michael Berman wrote: > >>> Great, thanks! I have all the new config property boilerplate in place > and > >>> I understand how it should wor

Re: [pool] POOL-272: per-key numTestsPerEvictionRun

2014-09-09 Thread Michael Berman
just insert None when a new key comes into existence, when we finish an iteration, or if we bail on an iteration after coming across a borrowed object). Does that sound reasonable to you? On Sat, Sep 6, 2014 at 5:22 PM, Phil Steitz wrote: > On 9/5/14 8:44 AM, Michael Berman wrote: > > I

Re: [pool] POOL-272: per-key numTestsPerEvictionRun

2014-09-05 Thread Michael Berman
in or the max? On Fri, Sep 5, 2014 at 11:28 AM, Phil Steitz wrote: > On 9/3/14 8:53 AM, Michael Berman wrote: > > Thanks for the feedback Phil! > > > > > >> One way to do this would be to have the current property be a cap on > >> the total number of tests perf

Re: [pool] POOL-272: per-key numTestsPerEvictionRun

2014-09-03 Thread Michael Berman
Thanks for the feedback Phil! > One way to do this would be to have the current property be a cap on > the total number of tests performed, but the new one basically > control the number done per key. So if, e.g. numTestsPerEvictionRun > is 12, numEvictionTestsPerKey (or whatever we decide to ca

[pool] POOL-272: per-key numTestsPerEvictionRun

2014-09-02 Thread Michael Berman
Hi all, I'm contemplating POOL-272, which Phil Steitz said he was considering including in 2.3. The issue proposes introducing a per-key variant of numTestsPerEvictionRun for GenericKeyedObjectPool. The current behavior of the GenericKeyedObjectPool eviction loop is to try to iterate over idle obje