Re: (commons-pool) branch POOL_2_X updated: Prepare for the next release candidate

2025-01-21 Thread Gary Gregory
On Tue, Jan 21, 2025 at 6:30 PM sebb wrote: > > On Mon, 20 Jan 2025 at 13:31, wrote: > > > > This is an automated email from the ASF dual-hosted git repository. > > > > ggregory pushed a commit to branch POOL_2_X > > in repository https://gitbox.apache.org/repos/asf/commons-pool.git > > > > > > T

Re: [VOTE] Release Apache Commons Pool 2.12.1 based on RC1

2025-01-21 Thread sebb
-1, the source archive does not contain all the files needed to build a release. Note that all the other components (apart from daemon, which is special) use a single src.xml file that creates both tar.gz and zip files. They all include the entire src directory structure. I'm not against keeping

Re: (commons-pool) branch POOL_2_X updated: Prepare for the next release candidate

2025-01-21 Thread sebb
On Mon, 20 Jan 2025 at 13:31, wrote: > > This is an automated email from the ASF dual-hosted git repository. > > ggregory pushed a commit to branch POOL_2_X > in repository https://gitbox.apache.org/repos/asf/commons-pool.git > > > The following commit(s) were added to refs/heads/POOL_2_X by this

Re: Decompressing Zstd-Compressed data ends with ZstdIOException: "truncated source"

2025-01-21 Thread Gary Gregory
Hello Mehmet, To narrow this down, I would try it from whatever command line tool Zstd might have. If that doesn't work, then it's likely the file is corrupted. If the Zstd CLI works, then I would try just using the Zstd library; if that doesn't work for you, then that's where the problem should

Decompressing Zstd-Compressed data ends with ZstdIOException: "truncated source"

2025-01-21 Thread Karaman, Mehmet
Hello, I am trying to uncompress zstd compressed files with the commons-compress library and I get the ZstdIOException "truncated source": com.github.luben.zstd.ZstdIOException: Truncated source   at com.github.luben.zstd.ZstdInputStreamNoFinalizer.readInternal(ZstdInputStreamNoFinalizer.ja

Re: [ALL] CRLF line endings causing problems

2025-01-21 Thread Piotr P. Karwasz
Hi Dávid, On 21.01.2025 18:44, Dávid Szigecsán wrote: I'm not 100% sure this is a valid concern at the moment, but I think it could be. You can add exceptions to a `.gitattribute` file. For example the `mvnw.cmd` file in Logging repos is configured to always have CRLF line endings[1]. Piot

Re: [ALL] CRLF line endings causing problems

2025-01-21 Thread Dávid Szigecsán
Hi, If the LF is forced by anything (git config, gitattribute, checkstyle, etc), what will happen to the file based tests where there is a purposefully CRLF line ending, because the test covers a fixed issue that was specifically related to windows files. E.g. in CSV. I mean files here for example

Re: [VOTE] Release Apache Commons Pool 2.12.1 based on RC1

2025-01-21 Thread Arnout Engelen
I have: * checked out git tag commons-pool-2.12.1-RC1 * verified it corresponds to a65fc3457817abf993fdb29b69912346a2b4838b * downloaded source zip and tgz * verified the hashes match c6c9731705c5d09f007a76350a35c3fb176184391923e8b1ab761b745f1256d79d0859b4f2802d065b6b9605174e771665debba26b4b1063d49