Re: [LANG] [DISCUSS] Java Modularity support in commons-lang3

2024-12-15 Thread Mark Struberg
> Am 14.12.2024 um 12:00 schrieb Piotr P. Karwasz : > > Hi Mark, > > On 9.12.2024 17:37, Mark Struberg wrote: >> c) try using this on a class which contains e.g. an ArrayList, a Set or a >> Map. It will e.g. use List#equals() which also does equals() on it's items >> (btw, I explained this to

Re: [VOTE] Release Apache Commons Collections 4.5.0-M3 based on RC1

2024-12-15 Thread Piotr P. Karwasz
Hi Gary, On 15.12.2024 16:46, Gary Gregory wrote: Please review the release candidate and vote. This vote will close no sooner than 72 hours from now. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... * The

Re: Subject: Proposal: Standardizing String Concatenation in Apache Commons

2024-12-15 Thread Peter Burka
I'm not sure Sun/Oracle ever formally specified this behavior, but as a JVM engineer since Java 0.98 I can attest to it. This behavior is also described in JEP-280: "Currently javac translates String concatenation into StringBuilder::append chains" (referring to Java 8). The advantages of using St

Re: Subject: Proposal: Standardizing String Concatenation in Apache Commons

2024-12-15 Thread Eric Bresie
What performance tests are define to help in determining before and after performance improvements? Eric Bresie ebre...@gmail.com On Sat, Dec 14, 2024 at 9:08 AM Serw wrote: > Dear Apache Commons Community, > > In my recent PR #1332, I replaced a StringBuilder usage with string > concatenation

Re: Subject: Proposal: Standardizing String Concatenation in Apache Commons

2024-12-15 Thread Elliotte Rusty Harold
On Sun, Dec 15, 2024 at 2:00 PM Peter Burka wrote: > > Before Java 9, javac always generated StringBuilder calls for string > concatenation (or StringBuffer prior to Java 2). Using + is less verbose, > generates the same code, is more readable, and, when we do finally bump the > compile target, wi

[VOTE] Release Apache Commons Collections 4.5.0-M3 based on RC1

2024-12-15 Thread Gary Gregory
Since Apache Commons Collections 4.5.0-M2 was released, we have fixed a few bugs and added enhancements, so I would like to release Apache Commons Collections 4.5.0-M3. Apache Commons Collections 4.5.0-M3 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/collecti

Re: Subject: Proposal: Standardizing String Concatenation in Apache Commons

2024-12-15 Thread Peter Burka
Before Java 9, javac always generated StringBuilder calls for string concatenation (or StringBuffer prior to Java 2). Using + is less verbose, generates the same code, is more readable, and, when we do finally bump the compile target, will generate better code. Peter On Sun, Dec 15, 2024, 7:13 AM

Re: Subject: Proposal: Standardizing String Concatenation in Apache Commons

2024-12-15 Thread Elliotte Rusty Harold
Thanks. In that case I'm -1 on this since it is not available in Java 8, and even in Java 9 is only possible, not necessarily implemented. We can revisit in a few years if the JDK has moved on by then. On Sun, Dec 15, 2024 at 1:05 AM Peter Burka wrote: > > I presume this is referring to > https: