Re: (commons-validator) 11/11: Fixed Javadoc errors

2024-11-18 Thread Emmanuel Bourg
Le 18/11/2024 à 17:38, Gary Gregory a écrit : Please revert "{@link java.lang.String}". The java.lang package is automatically in scope, just like in Java sources. I don't use Java 8 to build because it's EOL and doesn't generate the search box. FWIW, all release sites I've built recently were d

Re: (commons-validator) 11/11: Fixed Javadoc errors

2024-11-18 Thread Gary Gregory
Please revert "{@link java.lang.String}". The java.lang package is automatically in scope, just like in Java sources. I don't use Java 8 to build because it's EOL and doesn't generate the search box. FWIW, all release sites I've built recently were done with Java 17. Gary On Mon, Nov 18, 2024, 7

Re: (commons-validator) 08/11: Removed unnecessary lambdas in the tests

2024-11-18 Thread Gary Gregory
On Mon, Nov 18, 2024, 11:16 AM Mike Drob wrote: > In practical terms, what is the time cost? I am thinking in terms of the cumulative costs of running build after build on CI systems on many Java versions and sometimes many OSs. What also matters is showing best practices on JUnit 5 to contract

Re: (commons-validator) 08/11: Removed unnecessary lambdas in the tests

2024-11-18 Thread Mike Drob
In practical terms, what is the time cost? I imagined the lambda APIs existing to avoid heavy processing, like printing out the state of a database or other large complex graph. StringBuilder doesn't seem like a huge issue and the readability is nice. Have we spent more time writing these emails th

Re: (commons-validator) 08/11: Removed unnecessary lambdas in the tests

2024-11-18 Thread Gary Gregory
-1 you are undoing the port to JUnit 5. This commit is a classic JUnit mistake imo, please stop, these JUnit APIs exist for a reason: The lambdas avoid construction of failure message strings, which, as a pattern, add processing, can have side effects, and always creates more garbage. This is bad s

The maximum wait time for acquiring a resource from the commons Pool may exceed expectations.

2024-11-18 Thread 孙帅
Dear Apache Commons Development Team, I found an issue when using jedis to operate Redis database, Here is the issue link -> https://github.com/redis/jedis/issues/4014. we feel that it's a problem with the Commons pool. In situations where the connection is tight, the waiting time can be up t

Re: [VOTE] Release Apache Commons IO 2.18.0 based on RC1

2024-11-18 Thread Henri Biestro
[ +1 ] Builds & tests, project reports look good, site ok, nice documentation ( +1, no added dependency :-) ). Built using: Maven home: /Users/hbiestro/Java/apache-maven-3.8.6 Java version: 1.8.0_432, vendor: Azul Systems, Inc., runtime: /Library/Java/JavaVirtualMachines/zulu-8.jdk/Contents/Home

Re: (commons-compress) branch master updated: Replace org.apache.commons.io.Charsets with org.apache.commons.compress.utils.Charsets

2024-11-18 Thread Henri Biestro
> > It does not make sense to me to add any dependency (regardless of > size) for such minor simplifications. > [ +1 ] Adding a dependency should be done out of functional necessity, not to avoid one-liners and shading should only be used as the last possible solution. In the context of the

Re: (commons-compress) branch master updated: Replace org.apache.commons.io.Charsets with org.apache.commons.compress.utils.Charsets

2024-11-18 Thread Piotr P. Karwasz
Hi Gilles, On 16.11.2024 16:11, Gilles Sadowski wrote: Both sides have something in their favour; you are right in the short term, Gary is right in the longer term. [IMO] Wouldn't the project benefit from a common policy on how to deal with such issues (rather than be divisive, once more)? [I'd