Re: [pool] Resilience against factory outages (POOL-407)

2024-05-31 Thread Gary Gregory
No need to apologize 😀 We all have complex system to deal with all over the place. Gary On Fri, May 31, 2024, 5:55 PM Phil Steitz wrote: > Thx and sorry. > > Phil > > On Fri, May 31, 2024 at 1:45 PM Gary D. Gregory > wrote: > > > Hello Phil, > > > > Before you push, run 'mvn' (buy itself), thi

Re: [pool] Resilience against factory outages (POOL-407)

2024-05-31 Thread Phil Steitz
Thx and sorry. Phil On Fri, May 31, 2024 at 1:45 PM Gary D. Gregory wrote: > Hello Phil, > > Before you push, run 'mvn' (buy itself), this runs the default goal, which > contains all build checks. > > If see the code coverage report, regardless of coverage failures, run: > > mvn clean site -Dco

Re: [pool] Resilience against factory outages (POOL-407)

2024-05-31 Thread Gary D. Gregory
I updated the README's "Contributing" sections with: + Before you pushing a PR, run `mvn` (by itself), this runs the default goal, which contains all build checks. + To see the code coverage report, regardless of coverage failures, run `mvn clean site -Dcommons.jacoco.haltOnFailure=false` This

Re: [pool] Resilience against factory outages (POOL-407)

2024-05-31 Thread Gary D. Gregory
Hello Phil, Before you push, run 'mvn' (buy itself), this runs the default goal, which contains all build checks. If see the code coverage report, regardless of coverage failures, run: mvn clean site -Dcommons.jacoco.haltOnFailure=false I'll update the readme... TY, Gary On 2024/05/31 20:12:

Re: [pool] Resilience against factory outages (POOL-407)

2024-05-31 Thread Phil Steitz
The build worked locally for me fine. I could not get the site to build. Is there some sequence that I need to use to get the site to build? I did run Checksytle and Findbugs separately. What is the test coverage plugin and how do I run that? Phil On Fri, May 31, 2024 at 11:53 AM Gary Gregory

Re: [pool] Resilience against factory outages (POOL-407)

2024-05-31 Thread Gary Gregory
Hi Phil, Thank you for the note. I'll try to take a look soon. The new code causes the build to fail as it looks like not all of it is covered by unit tests. Gary On Fri, May 31, 2024, 2:29 PM Phil Steitz wrote: > I just committed a first attempt at providing the above, intended as a fix >

[pool] Resilience against factory outages (POOL-407)

2024-05-31 Thread Phil Steitz
I just committed a first attempt at providing the above, intended as a fix for POOL-407 and a lot of similar issues reported over the years. The scenario in POOL-407 is common when resource providers (like databases) go down: 1. makeObject requests start to fail and threads line up waiting on th

[ANNOUNCE] Apache Commons Net 3.11.0

2024-05-31 Thread Gary Gregory
The Apache Commons Net team is pleased to announce the release of Apache Commons Net 3.11.0. Apache Commons Net library contains a collection of network utilities and protocol implementations. Supported protocols include Echo, Finger, FTP, NNTP, NTP, POP3(S), SMTP(S), Telnet, and Whois. Maintenan

[RESULT][VOTE] Release Apache Commons Net 3.11.0 based on RC1

2024-05-31 Thread Gary Gregory
This vote thread passes with the following binding +1 votes: - Henri Biestro (henrib) - Gary Gregory (ggregory) - Rob Tompkins (chtompki) Gary On Thu, May 30, 2024 at 8:28 AM Rob Tompkins wrote: > > +1 > > > On May 28, 2024, at 8:09 PM, Gary Gregory wrote: > > > > We have fixed a few bugs and

Re: Re: [LANG] Support single quotes in DurationFormatUtils methods' formats

2024-05-31 Thread Daniel Watson
Honestly I think not supporting empty literals is just as big a limitation as not supporting single quotes, so IMO we'd just be trading one limitation for another. i.e. if someone were to need empty literals, the things they would have to do to use them are the same things they'd have to do to supp