Re: [LANG] EqualsBuilder#reflectionEquals feature brainstorming

2024-03-06 Thread Mark Struberg
The question to me is how we can make it more robust. In a Collection (but actually also in most lists) the order in which you get the values (Iterator or get(i)) is not deterministic. It can be different in one list than in another - even if they contain the exact same items. Not yet sure how t

Re: [VOTE] Release Apache Commons Compress 1.26.1 based on RC1

2024-03-06 Thread Gary Gregory
My +1 Gary On Tue, Mar 5, 2024 at 5:40 PM Gary Gregory wrote: > > We have fixed a few bugs and added some enhancements since Apache > Commons Compress 1.26.0 was released, so I would like to release > Apache Commons Compress 1.26.1. > > Apache Commons Compress 1.26.1 RC1 is available for review

Re: [VOTE] Release Apache Commons Compress 1.26.1 based on RC1

2024-03-06 Thread Melloware Inc
+1 (non-binding) I only checked it out and tested it locally with our application. On Tue, Mar 5, 2024 at 5:43 PM Gary Gregory wrote: > We have fixed a few bugs and added some enhancements since Apache > Commons Compress 1.26.0 was released, so I would like to release > Apache Commons Compress

Re: [LANG] EqualsBuilder#reflectionEquals feature brainstorming

2024-03-06 Thread Gary Gregory
Ah, right, custom "non-equalable" _inside_ Collections and Maps... For the diff, I'd suggest you test and iterable over a Collection instead of a List. Then you'd need a separate test and traversal for Map instances. (Still no common super-interface in Java 21 for Collections and Maps...) Gary

[VOTE] Release Apache Commons Configuration 2.10.0 based on RC1

2024-03-06 Thread Gary Gregory
We have fixed a few bugs and added some enhancements since Apache Commons Configuration 2.9.0 was released, so I would like to release Apache Commons Configuration 2.10.0. Apache Commons Configuration 2.10.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/confi

Re: [VOTE] Release Apache Commons Compress 1.26.1 based on RC1

2024-03-06 Thread Rob Tompkins
+1 tested builds on java 8 -21, site - reports all look good, RELEASE-NOTES.txt good, signatures good. > On Mar 5, 2024, at 5:40 PM, Gary Gregory wrote: > > We have fixed a few bugs and added some enhancements since Apache > Commons Compress 1.26.0 was released, so I would like to release > Apa

Re: [LANG] EqualsBuilder#reflectionEquals feature brainstorming

2024-03-06 Thread Mark Struberg
Hi Gregory! I did try this out and figured that I didn't think it though. Maybe I need to go a few steps back and explain the problem: I have the following constellation public class SomeInnerDTO {int field..} // NOT implements equals! public class TheOuterDTO{ List innerList;..} My problem is

Re: [LANG] EqualsBuilder#reflectionEquals feature brainstorming

2024-03-06 Thread Gary Gregory
This sounds like a good idea to try. I would call the option something else though. We would not skip calling equals if it is defined right? How about "useEqualsIfPresent". Gary On Wed, Mar 6, 2024, 5:03 AM Mark Struberg wrote: > Hi! > > I have a question about EqualsBuilder#reflectionEquals. F

[LANG] EqualsBuilder#reflectionEquals feature brainstorming

2024-03-06 Thread Mark Struberg
Hi! I have a question about EqualsBuilder#reflectionEquals. From Java9 onwards we get more and more nasty module problems. Mainly because the code tries to recurse into java.util.* classes as well. I know that I can use setBypassReflectionClasses for those. But wouldn't it be fine to have an ad