Re: [dbcp] Force close connections on fatal SQL Exceptions

2024-02-12 Thread Gary Gregory
I've used many JDBC drivers from different vendors, FOSS and proprietary, and if I've learned one thing, it is that each is its own world within the universe of the DBMS it operates in. It is impossible to write a generic tool; they all end up providing plugins for DB-specific features, sure, but

Re: [commons-net] issue: FTP other HTTP with Proxy-Authorization fail

2024-02-12 Thread sebb
On Mon, 12 Feb 2024 at 16:40, Elliotte Rusty Harold wrote: > > Be careful with this one. I don't have full context, but this looks > likely to be a real bug on some code paths and perhaps not a bug on > others. We'll need to make sure that the patch for the broken code > path doesn't break a curre

Re: [DBCP] Support request boundaries

2024-02-12 Thread Phil Steitz
On Tue, Jan 23, 2024 at 11:35 AM Phil Steitz wrote: > To make it easier to follow and find later, let's move the discussion > started in [1], [2] here. > > The request made in the Jira [1] and implemented in the PR [2] to send > beginRequest and endRequest messages to drivers seems reasonable to

[dbcp] Force close connections on fatal SQL Exceptions

2024-02-12 Thread Phil Steitz
In DBCP-595, a change is suggested to force close connections when a fatal SQL exception has occurred. As of Version 2.2 of DBCP, fatal exceptions are tracked and the fastFailValidation property can be set to fast fail validations when a fatal exception has occurred on a connection. This change w

Re: [commons-net] issue: FTP other HTTP with Proxy-Authorization fail

2024-02-12 Thread Elliotte Rusty Harold
Be careful with this one. I don't have full context, but this looks likely to be a real bug on some code paths and perhaps not a bug on others. We'll need to make sure that the patch for the broken code path doesn't break a currently working path. Specifically I'm worried about where \r\n might and

Re: [commons-net] issue: FTP other HTTP with Proxy-Authorization fail

2024-02-12 Thread Gary Gregory
Hi, Thank you for your email. I can't validate this without a test. The best path forward is for you to provide a PR in GitHub. TY! Gary On Mon, Feb 12, 2024, 10:15 AM Емельянов Юрий Владимирович wrote: > see FTPHTTPClient.tunnelHandshake > > current code is: > > if (proxyUsername !=

[commons-net] issue: FTP other HTTP with Proxy-Authorization fail

2024-02-12 Thread Емельянов Юрий Владимирович
see FTPHTTPClient.tunnelHandshake current code is:     if (proxyUsername != null && proxyPassword != null) {     final String auth = proxyUsername + ":" + proxyPassword;     final String header = "Proxy-Authorization: Basic " + Base64.getEncoder().encodeToString(auth.getByte