Looking more carefully at the extent of impact, I am -1 (non-binding) on
this change. I understand what you are trying to do, but a) I don't see
that the solution actually does it (see comments by Michael in PR) and b)
it is going to create a lot of pain for users who have to modify factories,
etc
On Mon, Jun 26, 2023 at 3:43 PM Gary Gregory wrote:
> Hi Phil,
>
> YW and thank you for the review.
>
> Yes, you are right that this is about POOL-269. While binary compatibility
> is preserved 100%, source compatibility is not. This is one of those rare
> cases where you can't make an omelette w
Hi Phil,
YW and thank you for the review.
Yes, you are right that this is about POOL-269. While binary compatibility
is preserved 100%, source compatibility is not. This is one of those rare
cases where you can't make an omelette without breaking some eggs ;-) Since
binary compatibility is preser
Hi Gary, First, thanks for doing this. There are a lot of good fixes in here.
I checked the build, sigs et al on a couple of platforms and did not
find anything major except one item. I will start with the
show-stopper (IMO) and then the other smaller things.
1. I get compilation failure when
+1
> On Jun 25, 2023, at 11:30 AM, Gary Gregory wrote:
>
> We have fixed a few bugs and added some enhancements since Apache
> Commons Build Plugin Maven Mojo 1.12 was released, so I would like to
> release Apache Commons Build Plugin Maven Mojo 1.13.
>
> Apache Commons Build Plugin Maven Mojo
+1
> On Jun 25, 2023, at 3:13 PM, Gary Gregory wrote:
>
> We have fixed a few bugs since Apache Commons Release Plugin 1.7 was
> released, so I would like to release Apache Commons Release Plugin
> 1.8.1.
>
> Apache Commons Release Plugin 1.8.1 RC1 is available for review here:
>https://di
[x] +1 Release these artifacts
Building OK from tag on
Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
Maven home: /opt/apache-maven-3.8.5
Java version: 17.0.7, vendor: Private Build, runtime:
/usr/lib/jvm/java-17-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS n
