Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1

2022-10-17 Thread Alex Herbert
On Mon, 17 Oct 2022 at 17:11, wrote: > > Hello > > > This is the logic from the current builder: > > DuplicateHeaderMode mode = allowDuplicateHeaderNames ? > > DuplicateHeaderMode.ALLOW_ALL : DuplicateHeaderMode.ALLOW_EMPTY > > This is true only if Builder.setAllowDuplicateHeaderNames is actually

Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1

2022-10-17 Thread sman81
Hello > This is the logic from the current builder: > DuplicateHeaderMode mode = allowDuplicateHeaderNames ? > DuplicateHeaderMode.ALLOW_ALL : DuplicateHeaderMode.ALLOW_EMPTY This is true only if Builder.setAllowDuplicateHeaderNames is actually called, which is at the library user's discretion.

Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1

2022-10-17 Thread Alex Herbert
On Mon, 17 Oct 2022 at 11:00, wrote: > > Hello > > CSV-264 (Add DuplicateHeaderMode) introduces bugs that should be fixed before > shipping 1.10.0 IMO > - missing default > - broken serialization of class CSVFormat > > I raised these issues in CSV-302. > > The serialization issue is caught by Rev

Re: Re: [jxpath] reported CVE and path forward

2022-10-17 Thread Khaled Yakdan
Great. Thank you! JXPath is still used, so it would be great if we can get the issue fixed as soon as possible. Let us know if you have feedback or further changes are needed. Cheers, Khaled On Sat, Oct 15, 2022 at 1:49 PM Gary Gregory wrote: > Sure, I can take a look, but it might be a few da

Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1

2022-10-17 Thread sman81
Hello CSV-264 (Add DuplicateHeaderMode) introduces bugs that should be fixed before shipping 1.10.0 IMO - missing default - broken serialization of class CSVFormat I raised these issues in CSV-302. The serialization issue is caught by Revapi. I had suggested to include Revapi in the project (C