Hi Alex/Gilles
Thank you both for the detailed review. I think I have a better
understanding now.
1) Refactor using Functional Interfaces and move current instance methods
to static methods
As suggested, I have attempted to refactor the Complex class to extract
the functions out to static metho
Hello,
> Do I understand correctly that the "resolveEntry" method which
you added behaves as my above "getEntry"?
Correct.
> If so, the latter can
replace both "resolve" methods, for a (c)leaner API.
That would work. I would need to add a matching "get" method to
PointSet to provide the same fu
[x] +1 Release these artifacts
Strangely `mvn clean test install site` generated the site with a layout
that looked really old, but with the correct data (release notes, changes,
reports, etc). Not too concerned as we can fix the site later if needed
(more likely to be something on my environment.
On it, as soon as I have some spare time between tasks at $work. Voting in
the next hours.
Cheers,
Bruno
On Tue, 15 Mar 2022 at 09:48, Gary Gregory wrote:
> Hi PMC folk, we need more reviews please.
>
> Gary
>
> On Fri, Mar 11, 2022, 08:32 Mark Thomas wrote:
>
> > Since the 1.2.4 release, the
Hi PMC folk, we need more reviews please.
Gary
On Fri, Mar 11, 2022, 08:32 Mark Thomas wrote:
> Since the 1.2.4 release, the minimum Java version has been updated to
> Java 7 and a handful of bugs have been fixed so I would like to release
> Apache Commons Daemon 1.3.0.
>
> Apache Commons Daemo
On 11/03/2022 13:32, Mark Thomas wrote:
Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.
[X] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
Tested with Apac
Hello.
Le lun. 14 mars 2022 à 16:19, Matt Juntunen
a écrit :
>
> Gilles,
>
> > it would be great to keep the tutorials/userguide in sync.
>
> Sounds good. I'll update the user guide in this PR.
>
> > I'm a little bit confused: Isn't it always the case that
> getEntry(p).getKey()
> will return t
Gilles,
> it would be great to keep the tutorials/userguide in sync.
Sounds good. I'll update the user guide in this PR.
> I'm a little bit confused: Isn't it always the case that
getEntry(p).getKey()
will return the originally inserted (i.e. "canonical") point (i.e. not "p")?
Map does not co
