Re: PR Review | Apache common math

2020-06-21 Thread Bhawna Sharma
PR has already one approval. Let me know if we are good to merge it now. https://github.com/apache/commons-math/pull/146 On Mon, 22 Jun 2020, 9:29 am Bhawna Sharma, <94sharmabha...@gmail.com> wrote: > Thanks for reviewing the PR. Updated the PR with the requested changes. > https://github.com/ap

Re: PR Review | Apache common math

2020-06-21 Thread Bhawna Sharma
Thanks for reviewing the PR. Updated the PR with the requested changes. https://github.com/apache/commons-math/pull/146 On Sun, Jun 21, 2020 at 2:09 PM Bhawna Sharma <94sharmabha...@gmail.com> wrote: > Hey, > Fifteen days back, I have raised one PR for Apache common math library. > Please find th

Re: [LAZY][VOTE] Commons Parent POM 51 based on RC2

2020-06-21 Thread Amey Jadiye
+1 Build and basic verifications look good. Installed from src locally. Tested on commons-text, commons-graph (forked repo). used LTS for testing. everything works fine. mvn -Duser.name=ameyjadiye -Dcommons.release.dryRun=true -Ptest-deploy clean verify package site deploy apache-rat:check clirr

Re: PR Review | Apache common math

2020-06-21 Thread Gilles Sadowski
Hello. Le dim. 21 juin 2020 à 13:11, Bhawna Sharma <94sharmabha...@gmail.com> a écrit : > > Hey, > Fifteen days back, I have raised one PR for Apache common math library. Thanks for your interest in the project. > Please find the URL https://github.com/apache/commons-math/pull/146 > It will be h

PR Review | Apache common math

2020-06-21 Thread Bhawna Sharma
Hey, Fifteen days back, I have raised one PR for Apache common math library. Please find the URL https://github.com/apache/commons-math/pull/146 It will be highly appreciable if you can review it and let me know your thoughts. Though the PR already has one approval. Regards, Bhawna