Re: [Math] PR #143

If you are telling about 144: yes, original codes runs like: f[0] = f0; f[1] = f1; f[2] = f[2-2] = f[0] = f[0] f[3] = f[3-2] = f[1] = f[1] f[4] = f[4-2] = f[2] = f[0] f[5] = f[5-2] = f[3] = f[1] the new codes runs like: f[0] = f0; f[1] = f1; f[2] = 2&1==0 ? f0 : f1 = f0 f[3] = 3&1==0 ? f0 : f1 = f

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

  [x] +1 Release these artifacts Build passing fine on Java 8, Ubuntu LTS. Site generated successfully too, reports look OK. Thanks Bruno On Sunday, 7 June 2020, 12:34:19 am NZST, Gary Gregory wrote: We have fixed a few bugs and added some enhancements since Apache Commons BCEL 6.4.

RE: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

I ran all my tests with Java 8 and Java 11 - looks good. +1 Mark -Original Message- From: Gary Gregory [mailto:ggreg...@apache.org] Sent: Friday, June 5, 2020 3:03 PM To: Commons Developers List Subject: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1 We have fixed a few bugs and a

Re: [Math] PR #143

Hi. 2020-06-06 14:21 UTC+02:00, Xeno Amess : > Alright, done. > This pr is now splitted into two prs. > https://github.com/apache/commons-math/pull/144 > https://github.com/apache/commons-math/pull/143 I think that there are issues with some of the changes (e.g. where the previous code used an "i

Re: [Math] PR #143

Hello. 2020-06-06 13:47 UTC+02:00, Xeno Amess : > Yes you are right. >>you must squash the commits. >>the commit messages are uninformative > > Usually I'd do them when commiter think this pr is ok, As said before, it's needlessly difficult to figure out the net changes when they result from seve

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

>it seems you are talking about moving some dependency management from this component to the parent POM. Yes, I'm talking about this part in bcel's pom.xml, org.apache.felix maven-bundle-plugin biz.aQute.bnd biz.aQute.bndlib

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

I am not sure what this has to do with the release, it seems you are talking about moving some dependency management from this component to the parent POM. This should not hold up the release unless I am missing something. Gary On Sat, Jun 6, 2020, 08:37 Xeno Amess wrote: > +0 > > @garydgregory

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

+0 @garydgregory 1. should we change commons-parent directly, thus we do not need to change every repo's pom.xml? 2. I see you add that plugin in in this repo's pom.xml. Is it really needed? can we simply add/change ${commons.felix.version} and ${

[VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

We have fixed a few bugs and added some enhancements since Apache Commons BCEL 6.4.1 was released, so I would like to release Apache Commons BCEL 6.5.0. Apache Commons BCEL 6.5.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/bcel/6.5.0-RC1 (svn revision 39954

Re: [Math] PR #143

Alright, done. This pr is now splitted into two prs. https://github.com/apache/commons-math/pull/144 https://github.com/apache/commons-math/pull/143 Thx. Xeno Amess 于2020年6月6日周六 下午7:47写道： > Yes you are right. > >you must squash the commits. > >the commit messages are uninformative > > Usually

Re: [Math] PR #143

Yes you are right. >you must squash the commits. >the commit messages are uninformative Usually I'd do them when commiter think this pr is ok, and then tell me we should merge it, and at that moment I squash it, and it get merged. the commit messages will be fixed at that time too. >partly revert

[Math] PR #143

Hi. 2020-06-06 10:18 UTC+02:00, GitBox : > > XenoAmess opened a new pull request #143: > URL: https://github.com/apache/commons-math/pull/143 > > >use System.arraycopy instead of loop. > There are several issues with this PR. It contains several commits, among which some seem, IIUC, to partl

[VFS] A wildcard scheme for archives

Hi all, The Commons Compress has the capality to provide many archive/compress types(zip, 7z, zstd, lz4 ...). I'm thinking about if we could provide a wildcard scheme for archives/compressors using Compress as the provider. WDYT? BTW : I can not connect to the Apache SMTP server(a.k.a mail-rely.a