Re: [collections] Bloom filters

2020-03-05 Thread Alex Herbert
The change to make the CountingBloomFilter an interface is in this PR [1]. This renames the existing CountingBloomFilter to MapCountingBloomFilter. I’ve left this alone and just done my work on new files: - CountingBloomFilter: An interface to extend BloomFilter - ArrayCountingBloomFilter: An im

Re: [math] Discuss: New feature MiniBatchKMeansClusterer

2020-03-05 Thread Gilles Sadowski
Hello. Le jeu. 5 mars 2020 à 13:23, chentao...@qq.com a écrit : > > [...] > It is a API change, how do we start it? I'd suggest putting the new API in a (temporary) package org.apache.math4.ml.clustering2 Regards, Gilles > [...] --

Re: [lang] NPE vs IAE

2020-03-05 Thread sebb
On Thu, 5 Mar 2020 at 19:29, Gilles Sadowski wrote: > > Le jeu. 5 mars 2020 à 16:12, sebb a écrit : > > > > On Wed, 4 Mar 2020 at 14:20, Gilles Sadowski wrote: > > > > > > Le mer. 4 mars 2020 à 15:16, sebb a écrit : > > > > > > > > On Wed, 4 Mar 2020 at 14:09, Gary Gregory > > > > wrote: > >

Re: [lang] NPE vs IAE

2020-03-05 Thread Gilles Sadowski
Le jeu. 5 mars 2020 à 19:04, Peter Verhas a écrit : > > Just my 2c: > > When you have an assertion in the code that throws an exception, be it NPE > or IAE then your code is less prone to errors during maintenance. In that > case, the assertion is there is the code, kind of documenting it. If the

Re: [lang] NPE vs IAE

2020-03-05 Thread Gilles Sadowski
Le jeu. 5 mars 2020 à 16:12, sebb a écrit : > > On Wed, 4 Mar 2020 at 14:20, Gilles Sadowski wrote: > > > > Le mer. 4 mars 2020 à 15:16, sebb a écrit : > > > > > > On Wed, 4 Mar 2020 at 14:09, Gary Gregory wrote: > > > > > > > > IMO, until we are all on Java 14 and benefit from its more detaile

Re: [lang] NPE vs IAE

2020-03-05 Thread Peter Verhas
Just my 2c: When you have an assertion in the code that throws an exception, be it NPE or IAE then your code is less prone to errors during maintenance. In that case, the assertion is there is the code, kind of documenting it. If the assertion is not there with the reasoning that the subsequent co

Re: [lang] NPE vs IAE

2020-03-05 Thread sebb
On Wed, 4 Mar 2020 at 14:20, Gilles Sadowski wrote: > > Le mer. 4 mars 2020 à 15:16, sebb a écrit : > > > > On Wed, 4 Mar 2020 at 14:09, Gary Gregory wrote: > > > > > > IMO, until we are all on Java 14 and benefit from its more detailed NPE > > > message, we need to call Validate.notNull _with a

Re: [math] Discuss: New feature MiniBatchKMeansClusterer

2020-03-05 Thread chentao...@qq.com
Hi, >Hello. > >2020-03-05 4:50 UTC+01:00, chentao...@qq.com : >> Hi, >> >>>Hi. >>> >>>Le ven. 28 févr. 2020 à 05:04, chentao...@qq.com a >>> écrit : -- chentao...@qq.com >Hi. > >Le jeu. 27 févr. 2020 à 06:17, chentao...@qq.com a > écr

Re: [math] Discuss: New feature MiniBatchKMeansClusterer

2020-03-05 Thread Gilles Sadowski
Hello. 2020-03-05 4:50 UTC+01:00, chentao...@qq.com : > Hi, > >>Hi. >> >>Le ven. 28 févr. 2020 à 05:04, chentao...@qq.com a >> écrit : >>> >>> >>> >>> >>> -- >>> chentao...@qq.com >>> >Hi. >>> > >>> >Le jeu. 27 févr. 2020 à 06:17, chentao...@qq.com a >>> > écrit : >>> >> >>> >> Hi, >