Re: [collections] Bloom filters

2020-02-19 Thread Claude Warren
Way back in your first post on this topic you talked about changing the AbstractBloomFilter to use: @Override public int cardinality() { int count = 0; for (final long bits : getBits()) { count += Long.bitCount(bits); } return count;

Re: [collections] Bloom filters

2020-02-19 Thread Alex Herbert
> On 19 Feb 2020, at 21:14, Claude Warren wrote: > > I think the compromise solution of removing the thrown exception and adding > an isInvalid() method makes sense and fits within the parameters of how the > counting Bloom filter should work. However, I think the add() and remove() > methods

Re: [collections] Bloom filters

2020-02-19 Thread Claude Warren
I think the compromise solution of removing the thrown exception and adding an isInvalid() method makes sense and fits within the parameters of how the counting Bloom filter should work. However, I think the add() and remove() methods should (or add and subtract) should only accept CountingBloomFi

Re: [math] Discuss: New feature MiniBatchKMeansClusterer

2020-02-19 Thread Gilles Sadowski
[Re-sending post so that it is attached to the original thread.] Hello. Le mar. 18 févr. 2020 à 04:49, 陈 涛 a écrit : > > Hi Gilles: > >I really do not know if anyone received my last mail, no one replay me for > a long time so I send it again and copy to you with another email system. Sorr

Re: [collections] checkstyle

2020-02-19 Thread Alex Herbert
On 18/02/2020 19:04, Gary Gregory wrote: - Avoid bikeshedding for what should be in these above files by picking Commons Lang's versions of these files. I've finished the PR for collections with the new checkstyle based on lang's configuration with a few additions: 1. I added a check for t