I think I went through your PRs and we have a green build on Travis now.
Thank you for your contributions.
Gary
On Fri, Aug 2, 2019, 09:06 Gary Gregory wrote:
> Thanks Rob, I should be able to review these over the weekend.
>
> Gary
>
> On Fri, Aug 2, 2019, 08:48 Rob Spoor wrote:
>
>> The PRs
All better now.
Gary
On Fri, Aug 9, 2019, 16:50 Gary Gregory wrote:
> Checkstyle is not perfect :-( I will hack that in a little bit...
>
> Gary
>
> On Fri, Aug 9, 2019, 15:22 Rob Spoor wrote:
>
>> See https://travis-ci.org/apache/commons-io/jobs/569951808. Two of the
>> errors report an unuse
Hi Rob,
Do you plan on creating a PR?
Gary
On Thu, Aug 1, 2019 at 7:00 AM Rob Spoor wrote:
> On 01/08/2019 12:31, Rob Spoor wrote:
> > Hi,
> >
> > CharSequenceReader is great, but I think there can be two improvements:
> >
> > 1) read(char[], int, int) currently calls read() several times, whi
I think checkstyle is correct here.
It's confusing to see an import that is only used by Javadoc.
On Fri, 9 Aug 2019 at 21:50, Gary Gregory wrote:
>
> Checkstyle is not perfect :-( I will hack that in a little bit...
>
> Gary
>
> On Fri, Aug 9, 2019, 15:22 Rob Spoor wrote:
>
> > See https://tra
Checkstyle is not perfect :-( I will hack that in a little bit...
Gary
On Fri, Aug 9, 2019, 15:22 Rob Spoor wrote:
> See https://travis-ci.org/apache/commons-io/jobs/569951808. Two of the
> errors report an unused import which is in fact used in Javadoc. The
> other is a protected method withou
See https://travis-ci.org/apache/commons-io/jobs/569951808. Two of the
errors report an unused import which is in fact used in Javadoc. The
other is a protected method without Javadoc.
-
To unsubscribe, e-mail: dev-unsubscr...@
