[IO] Travis builds fail for Java 7, 13 and ea

2019-08-01 Thread Rob Spoor
See subject. This occurs for both master and pull requests. For instance: https://travis-ci.org/apache/commons-io/builds/561807075?utm_source=github_status&utm_medium=notification - To unsubscribe, e-mail: dev-unsubscr...@commo

Re: [IO] Missing Reader / Writer implementations

2019-08-01 Thread Rob Spoor
Sure :) On 01/08/2019 18:03, Gary Gregory wrote: May I suggest one PR per class so we can avoid a giant PR to review? Gary On Thu, Aug 1, 2019, 11:57 Rob Spoor wrote: I guess that the full list is not necessary, but I've been working on a project where I could have used the following: * Ta

Re: [IO] Missing Reader / Writer implementations

2019-08-01 Thread Gary Gregory
May I suggest one PR per class so we can avoid a giant PR to review? Gary On Thu, Aug 1, 2019, 11:57 Rob Spoor wrote: > I guess that the full list is not necessary, but I've been working on a > project where I could have used the following: > > * TaggedReader: to distinguish between IOException

Re: [IO] Missing Reader / Writer implementations

2019-08-01 Thread Rob Spoor
I guess that the full list is not necessary, but I've been working on a project where I could have used the following: * TaggedReader: to distinguish between IOExceptions from reading and other IOExceptions. * TeeReader: a piece of code needs a Reader but I also need the contents that have alr

Re: [VOTE] Release Apache Commons BeanUtils 1.9.4 based on RC2

2019-08-01 Thread Rob Tompkins
Any other folks out there willing to validate? -Rob > On Jul 31, 2019, at 8:14 AM, Gary Gregory wrote: > > +1 > > You might want to rebuild the site using the "-P japicmp" profile because > that report is empty on the site > https://dist.apache.org/repos/dist/dev/commons/beanutils/1.9.4-RC2/si

Re: [IO] Missing Reader / Writer implementations

2019-08-01 Thread Gary Gregory
On Thu, Aug 1, 2019 at 6:39 AM Rob Spoor wrote: > Hi, > > I noticed that a lot of InputStream / OutputStream implementations do > not have a matching Reader / Writer implementation. Some would really be > useful. > > I've made an overview of classes that could be added: > * AutoCloseReader > * Br

Re: [IO] Missing Reader / Writer implementations

2019-08-01 Thread Gary Gregory
Hi Rob, I imagine that the classes you mention might be missing based on the YAGNI principle. I offer that you consider real use cases before plunging into implementation. We do not want to bloat this component just for the sake of completeness. Don't forget to get as close as possible to 100% co

Re: [IO] Improvements to CharSequenceReader

2019-08-01 Thread Rob Spoor
On 01/08/2019 12:31, Rob Spoor wrote: Hi, CharSequenceReader is great, but I think there can be two improvements: 1) read(char[], int, int) currently calls read() several times, which delegates to charSequence.charAt. That's fine in Java 8 and before, but in Java 9 the internal storage of Str

[IO] Missing Reader / Writer implementations

2019-08-01 Thread Rob Spoor
Hi, I noticed that a lot of InputStream / OutputStream implementations do not have a matching Reader / Writer implementation. Some would really be useful. I've made an overview of classes that could be added: * AutoCloseReader * BrokenReader * CloseShieldReader * ClosedReader * CountingReader

[IO] Improvements to CharSequenceReader

2019-08-01 Thread Rob Spoor
Hi, CharSequenceReader is great, but I think there can be two improvements: 1) read(char[], int, int) currently calls read() several times, which delegates to charSequence.charAt. That's fine in Java 8 and before, but in Java 9 the internal storage of String, StringBuilder and StringBuffer is