Re: [numbers/general] unlikely argument type warning

2018-12-13 Thread Gilles
On Thu, 13 Dec 2018 11:39:05 -0800, Eric Barnhill wrote: For the line: Assert.assertFalse(zero.equals(Double.valueOf(0))); What is it testing? Conceptually, I'd expect "assertTrue" (zero as a fraction is equal to zero as a double). Eclipse is producing a warning: "Unlikely argument type fo

Re: [numbers] propose making BigFraction an extension of Fraction

2018-12-13 Thread Gilles
Hi Eric. On Thu, 13 Dec 2018 11:20:12 -0800, Eric Barnhill wrote: Right now BigFraction and Fraction are separate parallel classes. I propose altering this so that BigFraction extends Fraction, overrides its methods, but also keeps its own unique methods. I think it would be an improvement t

Re: [RESULT][VOTE][LAZY] move commons git-wip repos to gitbox

2018-12-13 Thread Gary Gregory
Thank you Rob for taking care of this. Gary On Thu, Dec 13, 2018, 14:03 Rob Tompkins I’ve submitted the jira’s to INFRA for all of the following except [math], > [numbers], [rng], and [statistics] which IIRC @Gilles sorted out for us > (many thanks there) > > Cheers, > -Rob > > > On Dec 13, 2018

Re: [RESULT][VOTE][LAZY] move commons git-wip repos to gitbox

2018-12-13 Thread Rob Tompkins
I’ve submitted the jira’s to INFRA for all of the following except [math], [numbers], [rng], and [statistics] which IIRC @Gilles sorted out for us (many thanks there) Cheers, -Rob > On Dec 13, 2018, at 9:17 AM, Rob Tompkins wrote: > > This vote passes with the following +1’s: > > Stefan Bode

[numbers/general] unlikely argument type warning

2018-12-13 Thread Eric Barnhill
For the line: Assert.assertFalse(zero.equals(Double.valueOf(0))); Eclipse is producing a warning: "Unlikely argument type for equals(): Double seems to be unrelated to Fraction" Does anyone have a suggestion for how to handle this warning, thank you. Eric

[numbers] propose making BigFraction an extension of Fraction

2018-12-13 Thread Eric Barnhill
Right now BigFraction and Fraction are separate parallel classes. I propose altering this so that BigFraction extends Fraction, overrides its methods, but also keeps its own unique methods. I think it would be an improvement to the API to have both classes share the same interface (and indeed an

[CSV] Records as Lists

2018-12-13 Thread Gary Gregory
Hi All, I am looking for opinions on turning a CSV record into a list, as opposed to the minimal current implementation. There would be side-effects like a record becoming writable instead of read-only as the current implementation. Memory footprint would also be a concern. Please see https://gi

[Release-plugin] Auto-generated download page is wrong (Was: Returned post for annou...@apache.org)

2018-12-13 Thread Gilles
Hi. [See below, the rejected announce mail for Commons RNG v1.2.] Release candidates were generated with the "release-plugin".[1] The "xml" template files were generated using $ mvn -Prelease commons-build:download-page Please advise on the appropriate incantations (that would lead to the down

[RESULT][VOTE][LAZY] move commons git-wip repos to gitbox

2018-12-13 Thread Rob Tompkins
This vote passes with the following +1’s: Stefan Bodewig, Pascal Schumacher, Ethan Adler, Sebb, Gary Gregory, Oliver Heger, Eric Barnhill, Matt Sicker, Jochen Wiedmann, and with https://lists.apache.org/thread.html/6f7af4a106b6479970156959b31a73a26b4255e5ec2913e85aae547b@%3Cdev.commons.apache.o