Throw the first one and add others as being suppressed?
+1 to respect the naming and log any error (or store errors and let the
caller do it if logging is an issue, something like db.closeAll(); if
(db.hasError()) db.getErrors().forEach(log::error))
Le lun. 11 juin 2018 01:25, Remko Popma a écr
What’s the minimum target jre? If 8 or later, use java.util.BiConsumer.
Otherwise, create a custom @FunctionalInterface.
Chas
> On Jun 10, 2018, at 2:52 PM, Bruno P. Kinoshita
> wrote:
>
> Great catch indeed Gilles.
>
>
> So perhaps just leave the deprecated, with no replacement? And the
Good question.
I’ve never liked `close()` methods that throw exceptions. What is the client
code supposed to do?
It certainly makes sense to me to first fulfill the promise of “closeAll”,
which is to call `close` on all values (and not stop half-way through).
The remaining question is what to
Great catch indeed Gilles.
So perhaps just leave the deprecated, with no replacement? And then add a note
in the next release that those classes will be removed in the future?
B
From: Stephen Colebourne
To: Commons Developers List
Sent: Monday, 11 June 2018
Good spot. I think that means [lang] would have to have its own copy
of the JDK interfaces. or just deprecate the functionality without
replacement.
Stephen
On 10 June 2018 at 22:11, Gilles wrote:
> Hello.
>
> On Sun, 10 Jun 2018 21:34:49 +0200, Oliver Heger wrote:
>>
>> Hi Bruno,
>>
>> Am 10.06.
Hello.
On Sun, 10 Jun 2018 21:34:49 +0200, Oliver Heger wrote:
Hi Bruno,
Am 10.06.2018 um 00:52 schrieb Bruno P. Kinoshita:
Hi all,
There is a patch [1] for LANG-1339 [2] that I would like to merge.
The discussion around this issue can be found in the rest of this
e-mail thread.
The patch
GitHub user MrQubo opened a pull request:
https://github.com/apache/commons-cli/pull/26
[CLI-287] Allow whitespace-only header and footer
[CLI-287](https://issues.apache.org/jira/browse/CLI-287)
You can merge this pull request into a Git repository by running:
$ git pull https:
Hi all,
I tried to update the pom of [configuration] to commons-parent 46. When
I build the site I get the error below.
[configuration] has a number of dependencies marked marked as
true. These are obviously not added to the
classpath. I tried to follow the suggestion in the error message to
igno
Hi Bruno,
Am 10.06.2018 um 00:52 schrieb Bruno P. Kinoshita:
> Hi all,
>
> There is a patch [1] for LANG-1339 [2] that I would like to merge. The
> discussion around this issue can be found in the rest of this e-mail thread.
>
> The patch basically deprecates the existing classes that depend on
Github user coveralls commented on the issue:
https://github.com/apache/commons-pool/pull/6
[](https://coveralls.io/builds/17414700)
Coverage increased (+0.2%) to 85.17% when pulling
**75a75cd6d7571143fd065d9a
GitHub user wangyulin opened a pull request:
https://github.com/apache/commons-pool/pull/6
code review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wangyulin/commons-pool dev
Alternatively you can review and apply these chang
+1
Thank you very much for being the release manager!
Cheers,
Pascal
Am 09.06.2018 um 19:49 schrieb Gary Gregory:
We have fixed quite a few bugs and added some significant enhancements
since Apache Commons Text 1.3 was released, so I would like to release
Apache Commons Text 1.4.
Apache Commo
org.apache.commons.dbcp2.datasources.InstanceKeyDataSourceFactory.closeAll()
does not close all if one of delegated close() calls throws an exception.
I would think we would want to close all no matter what and then save the
first exception caught and rethrow it after all closes have been attempte
Github user sfuhrm commented on the issue:
https://github.com/apache/commons-cli/pull/25
Hi @kinow
thanks for your review! Oops, my maven build had a hickup and all tests
were green.
There's a design problem in the code you pointed me to. Every Option
instance may b
Github user sfuhrm commented on the issue:
https://github.com/apache/commons-cli/pull/25
Hi @kinow
thanks for your review! Oops, my maven build had a hickup and all tests
were green.
There's a design problem in the code you pointed me to. Every Option
instance may b
Github user sfuhrm closed the pull request at:
https://github.com/apache/commons-cli/pull/25
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Github user sfuhrm closed the pull request at:
https://github.com/apache/commons-cli/pull/25
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
On 10 June 2018 at 00:02, Bruno P. Kinoshita
wrote:
> Yes, that's my understanding. We would use require static on java.desktop,
> but users wouldn't have any issues as long as they did not use the version of
> the class that requires java.desktop.
>
> If the user want/needs to use those classes
18 matches
Mail list logo
