[GitHub] commons-collections issue #29: Added unit tests to increase code coverage

2017-10-13 Thread vamsi-kavuri
Github user vamsi-kavuri commented on the issue: https://github.com/apache/commons-collections/pull/29 @PascalSchumacher I am late by an hour. Decimal separators are added by gregory https://github.com/apache/commons-collections/commit/641aa1c663ebead0189bf001a06ee56463070ddb -

[GitHub] commons-collections pull request #31: Update test cases

2017-10-13 Thread vamsi-kavuri
Github user vamsi-kavuri closed the pull request at: https://github.com/apache/commons-collections/pull/31 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.a

[GitHub] commons-collections pull request #31: Update test cases

2017-10-13 Thread vamsi-kavuri
Github user vamsi-kavuri closed the pull request at: https://github.com/apache/commons-collections/pull/31 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.a

[GitHub] commons-collections pull request #31: Update test cases

2017-10-13 Thread vamsi-kavuri
GitHub user vamsi-kavuri opened a pull request: https://github.com/apache/commons-collections/pull/31 Update test cases Update test cases and correct locale issue mentioned in #29 You can merge this pull request into a Git repository by running: $ git pull https://github.com/v

Re: [COLLECTIONS] Test failures on Windows

2017-10-13 Thread Gary Gregory
OK, I should have that fixed up in the tests. Please give it a go. Gary On Thu, Oct 12, 2017 at 2:23 AM, Pascal Schumacher wrote: > With current master on windows 10 (java 7, 8, 9; german locale) the > occasional failures have been replace by constant failures: > > Failed tests: > MapUtilsTes

Re: [jcs] No access to assign an issue in JIRA (JCS-184)

2017-10-13 Thread Gary Gregory
Well, crud, when I look at the list of JIRA projects I can administer, I do not see Commons JCS. Anyone else? Gary On Thu, Oct 12, 2017 at 1:21 AM, Bruno P. Kinoshita < brunodepau...@yahoo.com.br.invalid> wrote: > Hi, > > I was working on JCS-184, a low hanging fruit in JCS. After writing the >

[GitHub] commons-io pull request #47: Add an IfStatement to check the return value of...

2017-10-13 Thread BruceKuiLiu
GitHub user BruceKuiLiu opened a pull request: https://github.com/apache/commons-io/pull/47 Add an IfStatement to check the return value of lockFile.delete(). This statement returns a value that is not checked. The return value should be checked since it can indicate an unusual o

Re: [codec] Releasing 1.11 and the binary "cli" jar

2017-10-13 Thread Gary Gregory
There is more than one class IIRC, still not worth it IMO. Gary On Oct 13, 2017 15:09, "Pascal Schumacher" wrote: > Am 13.10.2017 um 21:27 schrieb Gary Gregory: > >> What I am saying is that this jar should not even exist. The main jar is >> only ~300 KB, do we really need another jar to save a

Re: [codec] Releasing 1.11 and the binary "cli" jar

2017-10-13 Thread Pascal Schumacher
Am 13.10.2017 um 21:27 schrieb Gary Gregory: What I am saying is that this jar should not even exist. The main jar is only ~300 KB, do we really need another jar to save a few bytes, I think not. What exactly is in the cli jar? Looks like there is just a single small cli class https://github.co

[GitHub] commons-bcel pull request #17: BCEL-295 fix local variable live range length...

2017-10-13 Thread markro49
GitHub user markro49 opened a pull request: https://github.com/apache/commons-bcel/pull/17 BCEL-295 fix local variable live range length; add test case You can merge this pull request into a Git repository by running: $ git pull https://github.com/markro49/commons-bcel bcel295

Re: [codec] Releasing 1.11 and the binary "cli" jar

2017-10-13 Thread Gary Gregory
What I am saying is that this jar should not even exist. The main jar is only ~300 KB, do we really need another jar to save a few bytes, I think not. Unless I hear otherwise, I plan on removing this extra jar. Turning [codec] into a multi-module project is not worth it (IMO again). Thoughts? Ga

[GitHub] commons-bcel pull request #16: BCEL-296: correct empty constructor comments

2017-10-13 Thread markro49
GitHub user markro49 opened a pull request: https://github.com/apache/commons-bcel/pull/16 BCEL-296: correct empty constructor comments You can merge this pull request into a Git repository by running: $ git pull https://github.com/markro49/commons-bcel bcel296 Alternatively

[GitHub] commons-io pull request #46: IO-507: Rename ByteOrderUtils class to ByteOrde...

2017-10-13 Thread britter
GitHub user britter opened a pull request: https://github.com/apache/commons-io/pull/46 IO-507: Rename ByteOrderUtils class to ByteOrderParser and remove some logic for parsing strings "big" and "little", after discussions on the ML. You can merge this pull request into a Git re

[GitHub] commons-io pull request #42: [IO-546] ClosedOutputStream#flush should throw

2017-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-io/pull/42 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #29: Added unit tests to increase code coverage

2017-10-13 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-collections/pull/29 Thanks! Looking forward to the pull request! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

[ANNOUNCEMENT] Commons Configuration 2.2 Released

2017-10-13 Thread Oliver Heger
The Apache Commons Team is pleased to announce the availability of Apache Commons Configuration 2.2. The Apache Commons Configuration software library provides a generic configuration interface which enables an application to read configuration data from a variety of sources. Version 2.2 is anoth

[GitHub] commons-collections issue #29: Added unit tests to increase code coverage

2017-10-13 Thread vamsi-kavuri
Github user vamsi-kavuri commented on the issue: https://github.com/apache/commons-collections/pull/29 @PascalSchumacher Thanks for the feedback. I haven't thought of german locale. good catch. I will update it in a different PR. --- -

Re: [codec] Releasing 1.11 and the binary "cli" jar

2017-10-13 Thread Pascal Schumacher
Am 13.10.2017 um 13:28 schrieb Benedikt Ritter: Hi, Am 12.10.2017 um 23:42 schrieb Gary Gregory : Hi all, I starting preparing RC1 to release 1.11 and I see a "cli" jar being generated as documented in the POM: But the cli jar _is_ deployed when I run 'mvn clean d

Re: [codec] Releasing 1.11 and the binary "cli" jar

2017-10-13 Thread Benedikt Ritter
Hi, > Am 12.10.2017 um 23:42 schrieb Gary Gregory : > > Hi all, > > I starting preparing RC1 to release 1.11 and I see a "cli" jar being > generated as documented in the POM: > > > > But the cli jar _is_ deployed when I run 'mvn clean deploy -Prelease': > > [INFO] --