[vfs] release 2.2

2017-07-19 Thread Gary Gregory
Hi All: I plan on releasing 2.2 ASAP to pick up an important fix for ZIP and JAR files. If you want to fix JIRA and fiddle around, please do so ASAP. Gary

Re: [vfs] Lcurly=no (was: svn commit: r1802440 - /commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/jar/test/JarAttributesTestCase.java

2017-07-19 Thread Gary Gregory
We had talked a long time ago about changing the style to the {} style below but it was never done. Any IDE can automatically do that but I do not know how to tell Eclipse for example to ONLY do that. So if we can live we a tree-wide reformat, that's easy. Gary On Wed, Jul 19, 2017 at 5:15 PM, Be

Re: [daemon] moving to git ? and bump java version.

2017-07-19 Thread Gary Gregory
The code could be made better by fixing bug reported in JIRA... Gary On Wed, Jul 19, 2017 at 4:41 PM, wrote: > > Yes, that's mentioned in my previous mail, I was also curious to know from > the C developers here in dev-list that how can we make *that* C code > better? basically I'm looking fin

[vfs] Lcurly=no (was: svn commit: r1802440 - /commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/jar/test/JarAttributesTestCase.java

2017-07-19 Thread Bernd Eckenfels
Hello. I am not sure about changing that. It looks to me like most of the VFS code uses opening braces on new lines. I actually agree with that style. I would also accept to change it, but then completely. In fact the checkstyle template specifies curly = nl https://github.com/apache/commons-vf

RE: [daemon] moving to git ? and bump java version.

2017-07-19 Thread giorgio.zoppi
Yes, that's mentioned in my previous mail, I was also curious to know from the C developers here in dev-list that how can we make *that* C code better? basically I'm looking findbug, checkstyle, jococo, junit *equivalent* for C code. CodeSentry provide a cloud version for scanning opensource pr

[GitHub] commons-imaging issue #29: Improve various unit tests style

2017-07-19 Thread TheRealHaui
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/29 You're welcome. However, have to get used to the importance of style topics yet ... Regarding the GreyScaleRoundTripTest: Yes. However, I thing or better guess it has t

[GitHub] commons-imaging issue #29: Improve various unit tests style

2017-07-19 Thread jbduncan
Github user jbduncan commented on the issue: https://github.com/apache/commons-imaging/pull/29 Looks much better, thanks @TheRealHaui! As I discussed in #28, I'm sure there's area for improvement on the whitespace/readability front, but that would require running `mvn checkst

Re: [all] Removal of old pgp key from https://www.apache.org/dist/commons/KEYS

2017-07-19 Thread Matt Sicker
I think so. On 19 July 2017 at 10:46, Gary Gregory wrote: > On Jul 19, 2017 08:43, "Matt Sicker" wrote: > > On 18 July 2017 at 15:02, Stefan Bodewig wrote: > > > > We shouldn't remove any key that has been used to sign a release in the > > past. No matter how long in the past :-) > > > > What

Re: [all] Removal of old pgp key from https://www.apache.org/dist/commons/KEYS

2017-07-19 Thread Matt Sicker
On 18 July 2017 at 15:02, Stefan Bodewig wrote: > > We shouldn't remove any key that has been used to sign a release in the > past. No matter how long in the past :-) > What about expired keys? -- Matt Sicker

Re: [all] Removal of old pgp key from https://www.apache.org/dist/commons/KEYS

2017-07-19 Thread Gary Gregory
On Jul 19, 2017 08:43, "Matt Sicker" wrote: On 18 July 2017 at 15:02, Stefan Bodewig wrote: > > We shouldn't remove any key that has been used to sign a release in the > past. No matter how long in the past :-) > What about expired keys? Can't those still be used to validate old releases? Ga

Re: [all] Linking to sites will break or become misleading overtime.

2017-07-19 Thread Gary Gregory
I tried one approach for Commons Codec: https://commons.apache.org/proper/commons-codec/ See the nav bar under Site Archives. It's yet another thing to deal with during a release though. Gary On Jul 19, 2017 08:23, "Carl Hall" wrote: > This is a great idea. Something that hits closer to hom

Re: [all] Linking to sites will break or become misleading overtime.

2017-07-19 Thread Carl Hall
This is a great idea. Something that hits closer to home for me is how the API docs disappear for older versions. https://commons.apache.org/proper/commons-dbutils/apidocs/index.html vs. https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/apidocs/index.html For DbUtils, this is particularly int

[GitHub] commons-imaging issue #28: Increase code coverage one

2017-07-19 Thread TheRealHaui
Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/28 Done in #29. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] commons-imaging pull request #29: Improve various unit tests style

2017-07-19 Thread TheRealHaui
GitHub user TheRealHaui opened a pull request: https://github.com/apache/commons-imaging/pull/29 Improve various unit tests style Code formatting changed as desired in #27 and #28. You can merge this pull request into a Git repository by running: $ git pull https://github.com/T

[GitHub] commons-imaging pull request #28: Increase code coverage one

2017-07-19 Thread TheRealHaui
Github user TheRealHaui closed the pull request at: https://github.com/apache/commons-imaging/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

Re: [ANNOUNCE] Apache Commons Collections moved to git

2017-07-19 Thread Gary Gregory
On Jul 19, 2017 05:16, "Rob Tompkins" wrote: > On Jul 19, 2017, at 8:13 AM, Stefan Bodewig wrote: > > On 2017-07-19, Rob Tompkins wrote: > >> The Apache Commons Collections component has been moved to git. > > Many thanks for doing that, Rob! > > Are you following some kind of playbook with the

Re: [ANNOUNCE] Apache Commons Collections moved to git

2017-07-19 Thread Gary Gregory
On Jul 19, 2017 05:13, "Stefan Bodewig" wrote: On 2017-07-19, Rob Tompkins wrote: > The Apache Commons Collections component has been moved to git. Many thanks for doing that, Rob! +1 👍 Gary Are you following some kind of playbook with the git migration? If so, we should add one point: *

Re: commons-numbers git commit: NUMBERS-13: cosh() passes all tests

2017-07-19 Thread Gilles
Hi Eric. Constants should be declared "static final". Regards, Gilles On Wed, 19 Jul 2017 13:49:01 + (UTC), ericbarnh...@apache.org wrote: Repository: commons-numbers Updated Branches: refs/heads/complex-dev 1de701b3e -> c8db04d0a NUMBERS-13: cosh() passes all tests Project: http://

Re: [ANNOUNCE] Apache Commons Collections moved to git

2017-07-19 Thread Rob Tompkins
> On Jul 19, 2017, at 8:13 AM, Stefan Bodewig wrote: > > On 2017-07-19, Rob Tompkins wrote: > >> The Apache Commons Collections component has been moved to git. > > Many thanks for doing that, Rob! > > Are you following some kind of playbook with the git migration? If so, > we should add one

Re: [ANNOUNCE] Apache Commons Collections moved to git

2017-07-19 Thread Stefan Bodewig
On 2017-07-19, Rob Tompkins wrote: > The Apache Commons Collections component has been moved to git. Many thanks for doing that, Rob! Are you following some kind of playbook with the git migration? If so, we should add one point: * edit the svn:externals property of https://svn.apache.org/rep

[ANNOUNCE] Apache Commons Collections moved to git

2017-07-19 Thread Rob Tompkins
Hello all, The Apache Commons Collections component has been moved to git. The new source repository location is: https://git-wip-us.apache.org/repos/asf/commons-collections.git The old SVN source tree has been moved to an archi