Re: Pair of nulls

2017-05-10 Thread Gary Gregory
On Wed, May 10, 2017 at 10:58 PM, Matt Sicker wrote: > Matching the of() static factories, how about ImmutablePair.ofNull() > I like it but at the same time it feels to me like I am getting a NEW object like ImmutablePair.of(x, y) give me a new object. Might just be me ;-) Gary > On 11 May 20

Re: Pair of nulls

2017-05-10 Thread Matt Sicker
Matching the of() static factories, how about ImmutablePair.ofNull() On 11 May 2017 at 00:03, Gary Gregory wrote: > On Wed, May 10, 2017 at 9:27 PM, Matt Sicker wrote: > > > Wouldn't it make sense to expose typed methods like in > > Collections.emptyList() et al.? > > > > So in this case: > > I

Re: Pair of nulls

2017-05-10 Thread Gary Gregory
On Wed, May 10, 2017 at 9:27 PM, Matt Sicker wrote: > Wouldn't it make sense to expose typed methods like in > Collections.emptyList() et al.? > So in this case: ImmutablePair.nullPair() Gary > > On 10 May 2017 at 22:10, Javen O'Neal wrote: > > > +1 > > > > The of method should check if all

Re: Pair of nulls

2017-05-10 Thread Matt Benson
On May 10, 2017 11:27 PM, "Matt Sicker" wrote: Wouldn't it make sense to expose typed methods like in Collections.emptyList() et al.? +1 Matt On 10 May 2017 at 22:10, Javen O'Neal wrote: > +1 > > The of method should check if all elements are null, and if so to return > the NULL singleton.

Re: Pair of nulls

2017-05-10 Thread Matt Sicker
Wouldn't it make sense to expose typed methods like in Collections.emptyList() et al.? On 10 May 2017 at 22:10, Javen O'Neal wrote: > +1 > > The of method should check if all elements are null, and if so to return > the NULL singleton. This would reduce the number of objects created and > garbag

[GitHub] commons-compress issue #24: COMPRESS-391: Allow alignment on zip content

2017-05-10 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-compress/pull/24 [![Coverage Status](https://coveralls.io/builds/11469394/badge)](https://coveralls.io/builds/11469394) Coverage increased (+0.09%) to 84.309% when pulling **77f5ce3714e194704

Re: Pair of nulls

2017-05-10 Thread Javen O'Neal
+1 The of method should check if all elements are null, and if so to return the NULL singleton. This would reduce the number of objects created and garbage collected. So long as ImmutablePair and ImmutableTriple classes are final (not subclassable), then identity checking could be used in place o

Pair of nulls

2017-05-10 Thread Gary Gregory
Hi All, Any thoughts for or against adding the following to ImmutablePair: /** * An immutable pair of nulls. */ // This is not defined with generics to avoid warnings in call sites. @SuppressWarnings("rawtypes") public static final ImmutablePair NULL = ImmutablePair.of(

Re: [Numbers] NUMBERS-33

2017-05-10 Thread Raymond DeCampo
On Wed, May 10, 2017 at 10:49 AM, Gilles wrote: > Hi. > > > On Tue, 9 May 2017 12:59:40 -0400, Raymond DeCampo wrote: > >> If I make the method static and rename it to "gamma", then I can do the >>> >> much >> >>> simpler: >>> Stream d = numbers.parallelStream().map(Gamma::gamma); >>> >> >> I

Re: [COMPRESS] Anyone implemented "pigz"?

2017-05-10 Thread Matt Sicker
Would the scattering and gathering byte channel APIs in java.nio be helpful in splitting up a stream into chunks for parallel processing? On 10 May 2017 at 02:57, Stefan Bodewig wrote: > On 2017-05-10, Gary Gregory wrote: > > > I think the question is can/should [Compress] use any of the stock c

Re: [Numbers] NUMBERS-33

2017-05-10 Thread Gilles
Hi. On Tue, 9 May 2017 12:59:40 -0400, Raymond DeCampo wrote: If I make the method static and rename it to "gamma", then I can do the much simpler: Stream d = numbers.parallelStream().map(Gamma::gamma); It seems to me like the above, suggested by Stian earlier if I am not mistaken, is th

[GitHub] commons-rdf issue #34: COMMONSRDF-60: update commons-parent version

2017-05-10 Thread wikier
Github user wikier commented on the issue: https://github.com/apache/commons-rdf/pull/34 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] commons-rdf pull request #34: COMMONSRDF-60: update commons-parent version

2017-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] commons-rdf pull request #33: COMMONSRDF-59 - fix minor javadocs warnings

2017-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] commons-rdf issue #33: COMMONSRDF-59 - fix minor javadocs warnings

2017-05-10 Thread wikier
Github user wikier commented on the issue: https://github.com/apache/commons-rdf/pull/33 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] commons-rdf pull request #37: Minor documentation updates

2017-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] commons-rdf issue #37: Minor documentation updates

2017-05-10 Thread wikier
Github user wikier commented on the issue: https://github.com/apache/commons-rdf/pull/37 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[Math] Use standard naming (Was: [math] MATH-1413 ...)

2017-05-10 Thread Gilles
Hi. On Wed, 10 May 2017 07:59:16 -, ki...@apache.org wrote: Repository: commons-math Updated Branches: refs/heads/master ed1ce82d8 -> 60fdd5f3a MATH-1413 add generics to the Frequency class It is a good opportunity to also fix the method names. This class, among others, does not always

Re: [Math] Change on branch "master": Commons Math MasterBranch - Build # 55 - Failure

2017-05-10 Thread Bruno P. Kinoshita
Build passing for me in local workstation. Need to push one more change for PMD, so will see if next build passes. Wonder if just a glitch in one of Jenkins' slaves. Caused by: java.lang.InterruptedException at java.lang.Object.wait(Native Method) at hudson.remoting.FastPipedInpu

Re: [COMPRESS] Anyone implemented "pigz"?

2017-05-10 Thread Stefan Bodewig
On 2017-05-10, Gary Gregory wrote: > I think the question is can/should [Compress] use any of the stock code > in java.util.zip in a multi-threaded fashion for performance gains. We rely on java.util.zip.Deflater for DEFLATE which isn't thread safe by itself. But we could implement the same stra