Re: [lang] new concurrency annotations

2017-04-18 Thread Benedikt Ritter
Hi, > Am 19.04.2017 um 00:14 schrieb Gary Gregory : > > I'm OK with dropping them for 3.6 to avoid blocking the release and talking > some more. Either way. Okay, I’ll remove them from the code base before I prepare RC2. Benedikt > > Gary > > On Tue, Apr 18, 2017 at 2:30 PM, Pascal Schumache

Re: [lang] [LANG-1291] Provide annotations to document thread safety.

2017-04-18 Thread Benedikt Ritter
Hm, should we leave out the annotations from 3.6 to have more time for building consensus? Otherwise this will delay the 3.6 release... Benedikt Matt Sicker schrieb am Mi. 19. Apr. 2017 um 01:33: > You can work around annotation permissiveness by implementing an annotation > processor to fail c

Re: [text] index.xml: fix typo in apache license header

2017-04-18 Thread Benedikt Ritter
Wow, nice catch! schrieb am Di. 18. Apr. 2017 um 23:32: > Repository: commons-text > Updated Branches: > refs/heads/master a6a2732ff -> c9fd6cc68 > > > index.xml: fix typo in apache license header > > > Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo > Commit: > http://git-wi

Re: [lang] [LANG-1291] Provide annotations to document thread safety.

2017-04-18 Thread Matt Sicker
You can work around annotation permissiveness by implementing an annotation processor to fail compilations with improper combinations of annotations, but I feel that the annotation+enum approach is a lot simpler to enforce. On 18 April 2017 at 04:40, sebb wrote: > I think ThreadingBehavior is ve

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC1

2017-04-18 Thread Matt Sicker
Sounds like something that needs to be improved for Commons, quite possibly useful for other Apache projects, too. I've seen some neat continuous delivery style setups outside Apache, but that's not super feasible without integrating into automatic vote emails or something similar. Actually, that'

Re: [lang] new concurrency annotations

2017-04-18 Thread Gary Gregory
On Tue, Apr 18, 2017 at 2:14 PM, Emmanuel Bourg wrote: > Le 18/04/2017 à 23:06, Gary Gregory a écrit : > > > This use case does not make sense to me. If an object is immutable, then > it > > is thread safe. If you want to include an asynchronous external resource > as > > part of your object, the

Re: [lang] new concurrency annotations

2017-04-18 Thread Gary Gregory
I'm OK with dropping them for 3.6 to avoid blocking the release and talking some more. Either way. Gary On Tue, Apr 18, 2017 at 2:30 PM, Pascal Schumacher wrote: > I'm fine with either variant. We should not forget that the reason for > adding these annotations was documenting thread-safety of

Re: [lang] new concurrency annotations

2017-04-18 Thread Pascal Schumacher
I'm fine with either variant. We should not forget that the reason for adding these annotations was documenting thread-safety of lang classes. This should not hold up the release, the feature can be postponed to 3.7 if it requires further discussion/thought. Cheers, Pascal Am 18.04.2017 um 0

Re: [lang] new concurrency annotations

2017-04-18 Thread Emmanuel Bourg
Le 18/04/2017 à 23:06, Gary Gregory a écrit : > This use case does not make sense to me. If an object is immutable, then it > is thread safe. If you want to include an asynchronous external resource as > part of your object, then the object might not be in fact, immutable. > Speaking of a specific

Re: [lang] new concurrency annotations

2017-04-18 Thread Gary Gregory
On Tue, Apr 18, 2017 at 8:38 AM, Emmanuel Bourg wrote: > Le 18/04/2017 à 08:36, Gary Gregory a écrit : > > > Thoughts? > > I think I tend to prefer the JCIP style. ThreadingBehavior conflates the > notions of thread safety and immutability and intuitively I'd keep them > separate, even if they ar

Re: [lang] new concurrency annotations

2017-04-18 Thread Gary Gregory
On Tue, Apr 18, 2017 at 2:31 AM, sebb wrote: > On 18 April 2017 at 07:36, Gary Gregory wrote: > > Hi All: > > > > We have two styles for the new concurrency annotations in master: > > > > (1) JCIP > > (2) Apache HttpComponents Core > > Where are those located? > (1) JCIP inspired: org.apache.co

Re: [lang] new concurrency annotations

2017-04-18 Thread Emmanuel Bourg
Le 18/04/2017 à 08:36, Gary Gregory a écrit : > Thoughts? I think I tend to prefer the JCIP style. ThreadingBehavior conflates the notions of thread safety and immutability and intuitively I'd keep them separate, even if they are often closely related. An object could be immutable and not thread

Re: [ALL] The Commons Math issue

2017-04-18 Thread Gilles
On Tue, 18 Apr 2017 17:10:56 +0200, Emmanuel Bourg wrote: Le 18/04/2017 à 15:42, Gilles a écrit : And that's why "do-ocracy" should really matter more than "opinion". And how do you reach consensus if you aren't open to others opinions? Doing and not listening is just a variant of dictatorshi

Jenkins build is back to normal : Commons-Compress #243

2017-04-18 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Jenkins build is back to normal : Commons-Compress » Apache Commons Compress #243

2017-04-18 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@co

Re: [ALL] The Commons Math issue

2017-04-18 Thread Emmanuel Bourg
Le 18/04/2017 à 15:42, Gilles a écrit : > And that's why "do-ocracy" should really matter more than > "opinion". And how do you reach consensus if you aren't open to others opinions? Doing and not listening is just a variant of dictatorship, that's not my vision of an open community. Emmanuel Bo

Build failed in Jenkins: Commons-Compress #242

2017-04-18 Thread Apache Jenkins Server
See Changes: [bodewig] COMPRESS-387 [bodewig] COMPRESS-387 record changes -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely o

Build failed in Jenkins: Commons-Compress » Apache Commons Compress #242

2017-04-18 Thread Apache Jenkins Server
See Changes: [bodewig] COMPRESS-387 [bodewig] COMPRESS-387 record changes -- Established TCP socket on 35626 maven33-agent.jar already

[GitHub] commons-compress pull request #19: COMPRESS-387

2017-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-compress/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[RESULT][VOTE][LAZY] Migrate Apache Commons JEXL to Git

2017-04-18 Thread Emmanuel Bourg
No objection was raised, the vote therefore passes. I'll proceed with the migration. Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Build failed in Jenkins: Commons-Compress » Apache Commons Compress #241

2017-04-18 Thread Apache Jenkins Server
See Changes: [bodewig] COMPRESS-385, first draft [bodewig] COMPRESS-385, add ArchiveStreamFactory; undo boneheaded [bodewig] COMPRESS-385, flip jar/zip back to where they belo

Build failed in Jenkins: Commons-Compress #241

2017-04-18 Thread Apache Jenkins Server
See Changes: [bodewig] COMPRESS-385, first draft [bodewig] COMPRESS-385, add ArchiveStreamFactory; undo boneheaded [bodewig] COMPRESS-385, flip jar/zip back to where they belong [bodewig] COMPRESS-385 some twea

[GitHub] commons-compress pull request #18: COMPRESS-385

2017-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-compress/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Re: [ALL] The Commons Math issue

2017-04-18 Thread Gilles
Hello Stefan. On Tue, 18 Apr 2017 10:15:20 +0200, Stefan Bodewig wrote: [sorry, been offline for a few days and don't want to re-start a thread that seems to have come to a conclusion, just need to clarify one thing] I think that you have highlighted why "Commons" ways did not work for CM.

[GitHub] commons-fileupload pull request #6: improve GC by avoiding FileInput/Output-...

2017-04-18 Thread alexander-riss
GitHub user alexander-riss opened a pull request: https://github.com/apache/commons-fileupload/pull/6 improve GC by avoiding FileInput/Output-Streams bump compiler target from 1.5 to 1.7 see: https://bugs.openjdk.java.net/browse/JDK-8080225 You can merge this pull request

Re: [lang] [LANG-1291] Provide annotations to document thread safety.

2017-04-18 Thread sebb
I think ThreadingBehavior is very confusing as an enum. I expect enum values to be mutually exclusive, but STATELESS is also IMMUTABLE. And of course IMMUTABLE is SAFE. How do I know which enum to use? I don't think this is a good solution to the potential problem of someone using both @ThreadSa

Re: [lang] new concurrency annotations

2017-04-18 Thread sebb
On 18 April 2017 at 07:36, Gary Gregory wrote: > Hi All: > > We have two styles for the new concurrency annotations in master: > > (1) JCIP > (2) Apache HttpComponents Core Where are those located? I think it's important to be clear exactly what is being discussed. What about the annotations, Co

Re: Convert RNG help wanted into generic request

2017-04-18 Thread Eyal Allweil
Hi Gilles, As a Jira issue, RNG-37 is OK. But for something like Help Wanted, I would add a link to another implementation that can be used as a template and/or a page describing which interface to implement, what to test, that sort of thing. The idea is to make it easy for someone new to the pr

Re: [ALL] The Commons Math issue

2017-04-18 Thread Stefan Bodewig
[sorry, been offline for a few days and don't want to re-start a thread that seems to have come to a conclusion, just need to clarify one thing] On 2017-04-14, Gilles wrote: > On Fri, 14 Apr 2017 16:34:22 +0200, Stefan Bodewig wrote: >> On 2017-04-13, Gilles wrote: >>> On Thu, 13 Apr 2017 11:53:

Re: [COMPRESS] zip-bomb prevention for Z?

2017-04-18 Thread Stefan Bodewig
On 2017-04-14, Allison, Timothy B. wrote: >> enum wouldn't work for formats added via ServiceLoader. LZO supports a >> couple of names of its own and you couldn't inject them into the enum. > Doh! Got it. New code base...Sorry. No problem :-) I've taken a prolonged offline Easter-weekend, wi

Re: [lang] new concurrency annotations

2017-04-18 Thread Jörg Schaible
Benedikt Ritter wrote: > Hi, > >> Am 18.04.2017 um 08:36 schrieb Gary Gregory : >> >> Hi All: >> >> We have two styles for the new concurrency annotations in master: >> >> (1) JCIP >> (2) Apache HttpComponents Core >> >> I would like to delete (1) in favor of (2). I started this discussion >>

Re: [lang] new concurrency annotations

2017-04-18 Thread Gary Gregory
On Mon, Apr 17, 2017 at 11:55 PM, Benedikt Ritter wrote: > Hi, > > > Am 18.04.2017 um 08:36 schrieb Gary Gregory : > > > > Hi All: > > > > We have two styles for the new concurrency annotations in master: > > > > (1) JCIP > > (2) Apache HttpComponents Core > > > > I would like to delete (1) in fa