Re: [compress] Added in-memory support for zip and 7z

2016-10-20 Thread Stefan Bodewig
On 2016-10-20, wrote: > Even when a stream is not thread safe I try at least to make close() > safe/atomic as aborts and finalizers or shutdown hooks are natural > sources for concurrency – all using close(). true. > (However I guess it is less problematic for memory resources) In the case of

Re: [compress] Added in-memory support for zip and 7z

2016-10-20 Thread Stefan Bodewig
On 2016-10-20, M N wrote: > I have created tests for SeekableInMemoryByteChannel and spot small error. Great, thanks Maciej. > Attached is a patch with tests and proposed fix. The mailing list is set up to strip attachments (at least I don't see any). Could you attach it to a JIRA issue? Stefa

Re: [RNG] Evaluating work required for a multi-module project (Was: [ALL] Component with multiple modules?)

2016-10-20 Thread Artem Barger
​Hi Gilles,​ On Thu, Oct 20, 2016 at 4:47 PM, Gilles wrote: > Hi Artem. > > Would you be willing to create a branch containing actual > files? > > If so, since the break-down into modules I'm thinking of is > not the one you've taken below,[1] I suggest that you create > an "all-example" module,

AW: [compress] Added in-memory support for zip and 7z

2016-10-20 Thread ecki
Hello, Even when a stream is not thread safe I try at least to make close() safe/atomic as aborts and finalizers or shutdown hooks are natural sources for concurrency – all using close(). Using a AtomicBoolean or flag is good for that. (However I guess it is less problematic for memory resourc

Re: [compress] Added in-memory support for zip and 7z

2016-10-20 Thread M N
Hi Stefan, I have created tests for SeekableInMemoryByteChannel and spot small error. Attached is a patch with tests and proposed fix. Regarding thread safety I think would be more clear to remove volatile and document a class as not thread safe. I think the need for thread safe SeekableInMe

Re: [ALL] Component with multiple modules?

2016-10-20 Thread Gary Gregory
Not in Commons, but Log4j 2 has lots of modules. Gary On Thu, Oct 20, 2016 at 10:37 AM, Emmanuel Bourg wrote: > On 10/20/2016 01:55 PM, Gilles wrote: > > > Can you point me at a component that has a config supporting > > multiple modules? > > Hi Gilles, > > You can get a look at JCI. > > Emmanu

Re: [ALL] Component with multiple modules?

2016-10-20 Thread Emmanuel Bourg
On 10/20/2016 01:55 PM, Gilles wrote: > Can you point me at a component that has a config supporting > multiple modules? Hi Gilles, You can get a look at JCI. Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@commons.ap

Re: [ALL] Component with multiple modules?

2016-10-20 Thread Matt Benson
I never thought of that, but it seems as though you have stumbled onto a way in which generating the component site with the actual RC will always result in a problem. I'll rebuild the site from trunk. Thanks, Matt On Oct 20, 2016 8:20 AM, "Gilles" wrote: > On Thu, 20 Oct 2016 07:23:28 -0500, M

Re: [RNG] Evaluating work required for a multi-module project (Was: [ALL] Component with multiple modules?)

2016-10-20 Thread Artem Barger
On Thu, Oct 20, 2016 at 4:47 PM, Gilles wrote: > Hi Artem. > > Would you be willing to create a branch containing actual > files? > ​Yes, will do it today.​ > > If so, since the break-down into modules I'm thinking of is > not the one you've taken below,[1] I suggest that you create > an "all-

[RNG] Evaluating work required for a multi-module project (Was: [ALL] Component with multiple modules?)

2016-10-20 Thread Gilles
Hi Artem. Would you be willing to create a branch containing actual files? If so, since the break-down into modules I'm thinking of is not the one you've taken below,[1] I suggest that you create an "all-example" module, into which you'd move _all_ the code. I'd think that you should start from

Re: [ALL] Component with multiple modules?

2016-10-20 Thread Gilles
On Thu, 20 Oct 2016 07:23:28 -0500, Matt Benson wrote: On Oct 20, 2016 7:00 AM, "Gilles" wrote: Hi. Can you point me at a component that has a config supporting multiple modules? [weaver] is the most recently released multimodule Commons component. Thanks; but it seems that the web site

Re: [ALL] Component with multiple modules?

2016-10-20 Thread Matt Benson
On Oct 20, 2016 7:00 AM, "Gilles" wrote: > > Hi. > > Can you point me at a component that has a config supporting > multiple modules? > [weaver] is the most recently released multimodule Commons component. Matt > Thanks, > Gilles > > > ---

Re: [ALL] Component with multiple modules?

2016-10-20 Thread Artem Barger
On Thu, Oct 20, 2016 at 2:55 PM, Gilles wrote: > > Can you point me at a component that has a config supporting > multiple modules? ​I cannot point you to the multi module project within ASF commons, while it's not that hard to create one. First of all you can use "mvn archetype:generate" to cr

[ALL] Component with multiple modules?

2016-10-20 Thread Gilles
Hi. Can you point me at a component that has a config supporting multiple modules? Thanks, Gilles - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org