Re: [Math] "NaturalRankingTest"

2016-05-14 Thread Matt Sicker
3. Hardware bugs? Rare but possible. On 14 May 2016 at 08:01, Gilles wrote: > On Sat, 14 May 2016 02:47:18 +0200, Gilles wrote: > >> Hello. >> >> Test method "testNaNsFixedTiesRandom" (in the above unit test class) >> can pass or fail depending on the seed value. >> >> When seed is 1000, the tes

Re: [Math] Change on branch "develop": Commons Math DeveloperBranch - Build # 13 - Failure

2016-05-14 Thread Rob Tompkins
The problem here seems to be that https://repository.apache.org is unavailable (serving 503s). So this failure is not related to the commits on the branch. If it builds locally, then I would not be all that concerned. -Rob > On May 14, 2016, at 1:33 PM, Gilles wrote: > > Hi. > >> On Sat, 14

Re: [Math] Change on branch "develop": Commons Math DeveloperBranch - Build # 13 - Failure

2016-05-14 Thread Gilles
Hi. On Sat, 14 May 2016 17:19:38 + (UTC), Apache Jenkins Server wrote: The Apache Jenkins build system has built Commons Math DeveloperBranch (build #13) Status: Failure Check console output at https://builds.apache.org/job/Commons%20Math%20DeveloperBranch/13/ to view the results. When c

Re: svn commit: r1743780 - in /commons/proper/codec/trunk/src: changes/changes.xml main/java/org/apache/commons/codec/digest/Digest.java

2016-05-14 Thread Gary Gregory
Thank you for reviewing. I am AFK today so pardon my absence. Yes, shockingly, the bytes codes generated for a for each loop are different than for a for loop when traversing an array. I think you should find this discussed in some Jira and or ML at Apache in Commons or Log4j. You can verify this w

Re: svn commit: r1743780 - in /commons/proper/codec/trunk/src: changes/changes.xml main/java/org/apache/commons/codec/digest/Digest.java

2016-05-14 Thread sebb
On 14 May 2016 at 14:48, Gary Gregory wrote: > It might not matter here but in general I've stopped using foreach over > arrays because it creates an iterator, which means more garbage. Are you sure that Java creates an iterator for arrays? Besides, leaving the array.length calculation in the lo

Re: svn commit: r1743780 - in /commons/proper/codec/trunk/src: changes/changes.xml main/java/org/apache/commons/codec/digest/Digest.java

2016-05-14 Thread Gary Gregory
It might not matter here but in general I've stopped using foreach over arrays because it creates an iterator, which means more garbage. You're probably right that a foreach would be better just for this class. Gary On May 14, 2016 3:17 AM, "sebb" wrote: > Why does the code not use generic for

Re: [Math] "NaturalRankingTest"

2016-05-14 Thread Gilles
On Sat, 14 May 2016 02:47:18 +0200, Gilles wrote: Hello. Test method "testNaNsFixedTiesRandom" (in the above unit test class) can pass or fail depending on the seed value. When seed is 1000, the test passes. When seed is 1001, this failure occurs: Elements at index 1 differ. expected = 3.0 o

Re: svn commit: r1743778 - in /commons/proper/codec/trunk/src: changes/ main/java/org/apache/commons/codec/digest/ test/java/org/apache/commons/codec/digest/

2016-05-14 Thread sebb
On 14 May 2016 at 13:41, sebb wrote: > On 14 May 2016 at 02:33, wrote: >> Author: ggregory >> Date: Sat May 14 01:33:23 2016 >> New Revision: 1743778 >> >> URL: http://svn.apache.org/viewvc?rev=1743778&view=rev >> Log: >> [CODEC-211] Create enum MessageDigestAlgorithm and deprecate class >> Mes

Re: svn commit: r1743778 - in /commons/proper/codec/trunk/src: changes/ main/java/org/apache/commons/codec/digest/ test/java/org/apache/commons/codec/digest/

2016-05-14 Thread sebb
On 14 May 2016 at 02:33, wrote: > Author: ggregory > Date: Sat May 14 01:33:23 2016 > New Revision: 1743778 > > URL: http://svn.apache.org/viewvc?rev=1743778&view=rev > Log: > [CODEC-211] Create enum MessageDigestAlgorithm and deprecate class > MessageDigestAlgorithms Sorry, but I have to vote

Re: svn commit: r1743780 - in /commons/proper/codec/trunk/src: changes/changes.xml main/java/org/apache/commons/codec/digest/Digest.java

2016-05-14 Thread sebb
Why does the code not use generic for loops? If there is a good reason for this, it should be documented. If not, the code should use the new generic loop as it's simpler and less prone to errors (cannot use wrong index). On 14 May 2016 at 02:47, wrote: > Author: ggregory > Date: Sat May 14 01

Re: svn commit: r1743752 - /commons/proper/codec/trunk/src/changes/changes.xml

2016-05-14 Thread sebb
On 13 May 2016 at 21:41, wrote: > Author: ggregory > Date: Fri May 13 20:41:40 2016 > New Revision: 1743752 > > URL: http://svn.apache.org/viewvc?rev=1743752&view=rev > Log: > Use same attribute order in changes.xml. It would be better to change them all to put the issue attribute first. That m

Re: [CSV] Release 1.4

2016-05-14 Thread sebb
On 13 May 2016 at 16:26, Matt Sicker wrote: > You can use sftp to upload to home.apache.org. I'd recommend using > something other than the command line sftp program as there's no way to > recursively upload a bunch of stuff that way (people normally use scp for > that, but scp isn't supported on