Re: [TEXT] Review of the code base

2015-04-26 Thread Benedikt Ritter
Hello Phil, 2015-04-27 4:56 GMT+02:00 Phil Steitz : > On 4/26/15 3:14 AM, Benedikt Ritter wrote: > > 2015-04-26 11:52 GMT+02:00 Benedikt Ritter : > > > >> > >> 2015-04-19 17:29 GMT+02:00 Benedikt Ritter : > >> > >>> > >>> 2015-04-19 17:24 GMT+02:00 Benedikt Ritter : > >>> > Hello Bruno, > >>

[pool] JMX question

2015-04-26 Thread Gary Gregory
In I see: private String jmxNameBase = DEFAULT_JMX_NAME_PREFIX; Shouldn;t that be: private String jmxNameBase = DEFAULT_JMX_NAME_BASE; ? -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition JUnit in Ac

Re: [TEXT] Review of the code base

2015-04-26 Thread Phil Steitz
On 4/26/15 3:14 AM, Benedikt Ritter wrote: > 2015-04-26 11:52 GMT+02:00 Benedikt Ritter : > >> >> 2015-04-19 17:29 GMT+02:00 Benedikt Ritter : >> >>> >>> 2015-04-19 17:24 GMT+02:00 Benedikt Ritter : >>> Hello Bruno, 2015-04-19 12:15 GMT+02:00 Bruno P. Kinoshita < brunodepau...@y

Re: [TEXT] Review of the code base

2015-04-26 Thread Bruno P. Kinoshita
Great! Thanks for taking care of this Benedikt! There are four open issues. TEXT-2: Add Jaccard Index and Jaccard DistanceTEXT-10: A more complex Levenshtein distanceTEXT-14: Create a generic class that calculates a distance based on a similarity scoreTEXT-16: Improve HumanNameParser I've colle

[GitHub] commons-lang pull request: LANG-1119: Add StringUtils.rotate(Strin...

2015-04-26 Thread rikles
GitHub user rikles opened a pull request: https://github.com/apache/commons-lang/pull/69 LANG-1119: Add StringUtils.rotate(String, int) Implementation of a String rotation method You can merge this pull request into a Git repository by running: $ git pull https://github.com/rik

Re: [LANG] Next steps

2015-04-26 Thread Benedikt Ritter
2015-04-19 17:41 GMT+02:00 Benedikt Ritter : > Hi, > > 3.4 has been released. GitHub badges have been activated. Now we can start > the migration to git. Here is the Infra ticket [1] > The git mirror has been created at https://git-wip-us.apache.org/repos/asf/commons-lang.git The SVN tree is now

Re: [TEXT] Review of the code base

2015-04-26 Thread Benedikt Ritter
2015-04-26 11:52 GMT+02:00 Benedikt Ritter : > > > 2015-04-19 17:29 GMT+02:00 Benedikt Ritter : > >> >> >> 2015-04-19 17:24 GMT+02:00 Benedikt Ritter : >> >>> Hello Bruno, >>> >>> 2015-04-19 12:15 GMT+02:00 Bruno P. Kinoshita < >>> brunodepau...@yahoo.com.br>: >>> Thanks for the thorough code

Re: [TEXT] Review of the code base

2015-04-26 Thread Benedikt Ritter
2015-04-19 17:29 GMT+02:00 Benedikt Ritter : > > > 2015-04-19 17:24 GMT+02:00 Benedikt Ritter : > >> Hello Bruno, >> >> 2015-04-19 12:15 GMT+02:00 Bruno P. Kinoshita > >: >> >>> Thanks for the thorough code review Benedikt! Comments inline. >>> >>> > 1. IP clearance! There are several comments tal

Re: [LANG] Add ThreadUtils

2015-04-26 Thread Benedikt Ritter
Hello Hendrik, 2015-04-22 21:14 GMT+02:00 Hendrik Dev : > based on what i understand from this discussion i did some changes, > pls see > https://github.com/salyh/commons-lang/commit/12edd41ec7563368b03fa540af5c9a127bbfd89d > for the diff and > > https://github.com/salyh/commons-lang/blob/12edd41

Re: [LANG] Contribution adding some features in StringUtils

2015-04-26 Thread Benedikt Ritter
Hello Loic, welcome to the dev list! 2015-04-22 17:20 GMT+02:00 Loic Guibert : > Hello, > I wrote a personal class "StringHelper" using the StringUtils class and > containing some classic routines. > I think those could be added to the StringUtils class. > Nice that you've decided to contribute