Re: [csv] CSVPrinter ResultSet quoting

2014-10-31 Thread Gary Gregory
Hi Damjan, I think the process should be: create a JIRA, optionally attach a patch (or commit a fix, up to you) that includes a unit test that demonstrates that there is in fact a bug to fix. The test should fail without the fix of course. Thank you, Gary On Sat, Nov 1, 2014 at 12:33 AM, Damjan

[csv] CSVPrinter ResultSet quoting

2014-10-31 Thread Damjan Jovanovic
Hi Is there some reason CSVPrinter.printRecords(final ResultSet resultSet) retrieves all fields from the ResultSet using ResultSet.getString(), which makes QuoteMode.NON_NUMERIC quote numbers? This seems to work a lot better: Index: src/main/java/org/apache/commons/csv/CSVPrinter.java ==

Re: [exec] Release 1.3

2014-10-31 Thread Gary Gregory
My thought is to just push out a new release asap to get the current fixes out. Whatever makes it under the 1.3 wire is up to someone to volunteer. Otherwise it'll be 1.4. Gary Original message From: Emmanuel Bourg Date:10/31/2014 08:00 (GMT-05:00) To: Commons Developers L

Re: [exec] Release 1.3

2014-10-31 Thread Emmanuel Bourg
Le 29/10/2014 15:57, Gary Gregory a écrit : > I see some changes (see changes.xml) that ready to go for a 1.3. Does any > one have more to do for 1.3? Any one feels like an RM? That would be great to figure out what's wrong in EXEC-86 for the next release. Emmanuel Bourg ---