Re: Use of final modifiers - WAS svn commit: r1632171 [1/20] - in /commons/proper/beanutils/trunk/src: main/java/org/apache/commons/beanutils/ main/java/org/apache/commons/beanutils/converters/ main/j

2014-10-28 Thread Phil Steitz
On 10/28/14 8:46 AM, Benedikt Ritter wrote: > 2014-10-28 13:18 GMT+01:00 Gary Gregory : > >> On Tue, Oct 28, 2014 at 5:52 AM, Torsten Curdt wrote: >> You know that Java has no out variables (as it is call by value) and >> the final identifier does not make an object read only. So in fact

Re: Use of final modifiers - WAS svn commit: r1632171 [1/20] - in /commons/proper/beanutils/trunk/src: main/java/org/apache/commons/beanutils/ main/java/org/apache/commons/beanutils/converters/ main/j

2014-10-28 Thread Benedikt Ritter
2014-10-28 13:18 GMT+01:00 Gary Gregory : > On Tue, Oct 28, 2014 at 5:52 AM, Torsten Curdt wrote: > > > > > > > You know that Java has no out variables (as it is call by value) and > the > > > final identifier does not make an object read only. So in fact having > > final > > > modifiers would mi

Re: Use of final modifiers - WAS svn commit: r1632171 [1/20] - in /commons/proper/beanutils/trunk/src: main/java/org/apache/commons/beanutils/ main/java/org/apache/commons/beanutils/converters/ main/j

2014-10-28 Thread Gary Gregory
On Tue, Oct 28, 2014 at 5:52 AM, Torsten Curdt wrote: > > > > You know that Java has no out variables (as it is call by value) and the > > final identifier does not make an object read only. So in fact having > final > > modifiers would misslead you even more. > > > > The last sentence is a bit o

Re: Use of final modifiers - WAS svn commit: r1632171 [1/20] - in /commons/proper/beanutils/trunk/src: main/java/org/apache/commons/beanutils/ main/java/org/apache/commons/beanutils/converters/ main/j

2014-10-28 Thread Torsten Curdt
> > You know that Java has no out variables (as it is call by value) and the > final identifier does not make an object read only. So in fact having final > modifiers would misslead you even more. > The last sentence is a bit of theory. I don't see that to be true for me at least. Following some

Re: Use of final modifiers - WAS svn commit: r1632171 [1/20] - in /commons/proper/beanutils/trunk/src: main/java/org/apache/commons/beanutils/ main/java/org/apache/commons/beanutils/converters/ main/j

2014-10-28 Thread James Sawle
Whilst with primitives it is call by value with objects it is not, and whilst the final modifier does not stop a method from changing an internal value, it is acknowledgement that they won't, read writings by Joshua Bolchdku h m Sent from my iPhone > On 28 Oct 2014, at 08:55, Bernd wrote: > >

Re: Use of final modifiers - WAS svn commit: r1632171 [1/20] - in /commons/proper/beanutils/trunk/src: main/java/org/apache/commons/beanutils/ main/java/org/apache/commons/beanutils/converters/ main/j

2014-10-28 Thread Bernd
Hmm, You know that Java has no out variables (as it is call by value) and the final identifier does not make an object read only. So in fact having final modifiers would misslead you even more. Actually I like having final fields and variables (for example it avoids unneeded initialisation). On t

Re: Use of final modifiers - WAS svn commit: r1632171 [1/20] - in /commons/proper/beanutils/trunk/src: main/java/org/apache/commons/beanutils/ main/java/org/apache/commons/beanutils/converters/ main/j

2014-10-28 Thread James Sawle
I have no view on the use of final modifiers on variables within methods; however on the parameters I think it is very important so that the code self documents to the caller the behaviour that they should expect. Recently I was bitten by a library that I was using in a multithreaded application

Re: Use of final modifiers - WAS svn commit: r1632171 [1/20] - in /commons/proper/beanutils/trunk/src: main/java/org/apache/commons/beanutils/ main/java/org/apache/commons/beanutils/converters/ main/j

2014-10-28 Thread Benedikt Ritter
I agree with Oliver. This change is just of cosmetic value and makes it harder to apply patches (the same applies for the "sort methods in abc order" changes IMHO). If we come to the consensus that we want a final key word everywhere, we should add that to our code analysis tools configuration. For