[GitHub] commons-lang pull request: Replace string

2014-10-23 Thread otaviojava
GitHub user otaviojava opened a pull request: https://github.com/apache/commons-lang/pull/36 Replace string During the Java compilation performance the JDK does improvements with String, this way, these may be replaced with java.lang.String expressions which results in simpler and

Re: [compress][imaging] generalise/publicise commons-compress LZW implementation?

2014-10-23 Thread Stefan Bodewig
On 2014-10-23, Damjan Jovanovic wrote: > I've been hoping to steal commons-compress's cleaner and faster LZW > decompressor, and use it in commons-imaging for TIFF and GIF files, > and I've finally managed to make a patch to that effect. Cool. > This requires moving LZWInputStream to a > org.apa

Re: [compress][imaging] generalise/publicise commons-compress LZW implementation?

2014-10-23 Thread Emmanuel Bourg
Le 23/10/2014 23:07, Torsten Curdt a écrit : > Using the maven-shade-plugin would be the better choice IMO. +1 Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h.

Re: [compress][imaging] generalise/publicise commons-compress LZW implementation?

2014-10-23 Thread Torsten Curdt
> > > > I think it is a good idea make [imaging] depend on [compress]. > > > > Do you mean depend in general, or as opposed to the current use of the > > maven-shade-plugin to "half-depend" on it? > > > > I mean plain and simple depend. > Using the maven-shade-plugin would be the better choice IMO

Re: svn commit: r1632171 [1/20] - in /commons/proper/beanutils/trunk/src: main/java/org/apache/commons/beanutils/ main/java/org/apache/commons/beanutils/converters/ main/java/org/apache/commons/be

2014-10-23 Thread Gary Gregory
Patches go stale no matter what... Gary Original message From: Oliver Heger Date:10/23/2014 15:34 (GMT-05:00) To: dev@commons.apache.org Subject: Re: svn commit: r1632171 [1/20] - in /commons/proper/beanutils/trunk/src: main/java/org/apache/commons/beanutils/ main/java/o

Re: svn commit: r1632171 [1/20] - in /commons/proper/beanutils/trunk/src: main/java/org/apache/commons/beanutils/ main/java/org/apache/commons/beanutils/converters/ main/java/org/apache/commons/beanut

2014-10-23 Thread Gary Gregory
This is my reasoning: http://garygregory.wordpress.com/2013/01/26/the-final-kiss-in-java/ Gary On Thu, Oct 23, 2014 at 3:34 PM, Oliver Heger wrote: > There was no reaction on my comment so far. > > I am tempted to -1 this commit. There is already a report about a patch > which cannot be applied

Re: svn commit: r1632171 [1/20] - in /commons/proper/beanutils/trunk/src: main/java/org/apache/commons/beanutils/ main/java/org/apache/commons/beanutils/converters/ main/java/org/apache/commons/beanut

2014-10-23 Thread Paul Benedict
I do not not like "final" used this way. Unless you have a constant or a language mandating "final" for a particular usage, this is unnecessary noise to the code. Cheers, Paul On Thu, Oct 23, 2014 at 2:34 PM, Oliver Heger wrote: > There was no reaction on my comment so far. > > I am tempted to

Re: svn commit: r1632171 [1/20] - in /commons/proper/beanutils/trunk/src: main/java/org/apache/commons/beanutils/ main/java/org/apache/commons/beanutils/converters/ main/java/org/apache/commons/beanut

2014-10-23 Thread Oliver Heger
There was no reaction on my comment so far. I am tempted to -1 this commit. There is already a report about a patch which cannot be applied (comment to [1]). Oliver [1] https://issues.apache.org/jira/browse/BEANUTILS-417 Am 16.10.2014 um 21:22 schrieb Oliver Heger: > To be honest, I really don'

Re: [JCS] release?

2014-10-23 Thread Romain Manni-Bucau
right, I expected a "whole project" assembly, don't we do it? Romain Manni-Bucau @rmannibucau http://www.tomitribe.com http://rmannibucau.wordpress.com https://github.com/rmannibucau 2014-10-23 14:48 GMT+02:00 Thomas Vandahl : > On 22.10.14 21:07, Romain Manni-Bucau wrote: >> hi >> >> since rec

Re: [compress][imaging] generalise/publicise commons-compress LZW implementation?

2014-10-23 Thread Gary Gregory
On Thu, Oct 23, 2014 at 11:32 AM, Emmanuel Bourg wrote: > Le 23/10/2014 17:27, Gary Gregory a écrit : > > > I do not see the dep, are we looking at the same sources? > > I looked at the patch he attached to his mail. > Whoops, my bad, sorry. Gary > > Emmanuel Bourg > > > --

Re: [compress][imaging] generalise/publicise commons-compress LZW implementation?

2014-10-23 Thread Gary Gregory
On Thu, Oct 23, 2014 at 1:12 PM, Damjan Jovanovic wrote: > On Thu, Oct 23, 2014 at 5:05 PM, Gary Gregory > wrote: > > On Thu, Oct 23, 2014 at 12:42 AM, Damjan Jovanovic > > wrote: > > > >> Hi > >> > >> I've been hoping to steal commons-compress's cleaner and faster LZW > >> decompressor, and us

Re: [compress][imaging] generalise/publicise commons-compress LZW implementation?

2014-10-23 Thread Damjan Jovanovic
On Thu, Oct 23, 2014 at 2:38 PM, Emmanuel Bourg wrote: > Le 23/10/2014 06:42, Damjan Jovanovic a écrit : > >> I've been hoping to steal commons-compress's cleaner and faster LZW >> decompressor, and use it in commons-imaging for TIFF and GIF files, >> and I've finally managed to make a patch to th

Re: [compress][imaging] generalise/publicise commons-compress LZW implementation?

2014-10-23 Thread Damjan Jovanovic
On Thu, Oct 23, 2014 at 5:05 PM, Gary Gregory wrote: > On Thu, Oct 23, 2014 at 12:42 AM, Damjan Jovanovic > wrote: > >> Hi >> >> I've been hoping to steal commons-compress's cleaner and faster LZW >> decompressor, and use it in commons-imaging for TIFF and GIF files, >> and I've finally managed t

Re: [compress][imaging] generalise/publicise commons-compress LZW implementation?

2014-10-23 Thread Emmanuel Bourg
Le 23/10/2014 17:27, Gary Gregory a écrit : > I do not see the dep, are we looking at the same sources? I looked at the patch he attached to his mail. Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

Re: [compress][imaging] generalise/publicise commons-compress LZW implementation?

2014-10-23 Thread Gary Gregory
On Thu, Oct 23, 2014 at 8:38 AM, Emmanuel Bourg wrote: > Le 23/10/2014 06:42, Damjan Jovanovic a écrit : > > > I've been hoping to steal commons-compress's cleaner and faster LZW > > decompressor, and use it in commons-imaging for TIFF and GIF files, > > and I've finally managed to make a patch t

Re: [compress][imaging] generalise/publicise commons-compress LZW implementation?

2014-10-23 Thread Gary Gregory
On Thu, Oct 23, 2014 at 8:38 AM, Emmanuel Bourg wrote: > Le 23/10/2014 06:42, Damjan Jovanovic a écrit : > > > I've been hoping to steal commons-compress's cleaner and faster LZW > > decompressor, and use it in commons-imaging for TIFF and GIF files, > > and I've finally managed to make a patch t

Re: [compress][imaging] generalise/publicise commons-compress LZW implementation?

2014-10-23 Thread Gary Gregory
On Thu, Oct 23, 2014 at 8:38 AM, Emmanuel Bourg wrote: > Le 23/10/2014 06:42, Damjan Jovanovic a écrit : > > > I've been hoping to steal commons-compress's cleaner and faster LZW > > decompressor, and use it in commons-imaging for TIFF and GIF files, > > and I've finally managed to make a patch t

Re: [VOTE] Release Commons Parent 35-RC1

2014-10-23 Thread Gary Gregory
My +1 Gary On Wed, Oct 22, 2014 at 1:43 AM, Gary Gregory wrote: > Hello All, > > The Apache Commons Parent POM provides common settings for all Apache > Commons components. > > This is a VOTE to release Commons Parent 35-RC1. > > Changes in this version include: > > New features: > o Add link t

Re: [compress][imaging] generalise/publicise commons-compress LZW implementation?

2014-10-23 Thread Gary Gregory
On Thu, Oct 23, 2014 at 12:42 AM, Damjan Jovanovic wrote: > Hi > > I've been hoping to steal commons-compress's cleaner and faster LZW > decompressor, and use it in commons-imaging for TIFF and GIF files, > and I've finally managed to make a patch to that effect. > > This requires moving LZWInput

Re: [JCS] release?

2014-10-23 Thread Thomas Vandahl
On 22.10.14 21:07, Romain Manni-Bucau wrote: > hi > > since recently i get: > > [INFO] [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-assembly-plugin:2.4:single > (source-release-assembly) on project commons-jcs: Error reading > assemblies: Error locating assembly descriptor: > s

Re: [compress][imaging] generalise/publicise commons-compress LZW implementation?

2014-10-23 Thread Emmanuel Bourg
Le 23/10/2014 06:42, Damjan Jovanovic a écrit : > I've been hoping to steal commons-compress's cleaner and faster LZW > decompressor, and use it in commons-imaging for TIFF and GIF files, > and I've finally managed to make a patch to that effect. That's great to be able to share the code, thank y