Re: [pool] time to cut 2.3

2014-10-02 Thread sebb
On 2 October 2014 18:48, Jacopo Cappellato wrote: > > On Oct 2, 2014, at 7:24 PM, Mark Thomas wrote: > >>> @@ -311,12 +310,8 @@ >>> // Override getMessage to avoid creating objects and formatting >>> // dates unless the log message will actually be used. >>> @Override >>>

Re: [GitHub] commons-math pull request: Updated the example documentation for t...

2014-10-02 Thread Ole Ersoy
On 10/02/2014 02:18 PM, Phil Steitz wrote: On 10/2/14 11:33 AM, Ole Ersoy wrote: Hi, On 10/02/2014 11:34 AM, Gilles wrote: Hello. On Thu, 02 Oct 2014 10:51:53 -0500, Ole Ersoy wrote: Hello Luc, Gilles, and Benedikt, I'm here :). From my limited github experience, I do think most contribu

Re: [GitHub] commons-math pull request: Updated the example documentation for t...

2014-10-02 Thread Phil Steitz
On 10/2/14 11:33 AM, Ole Ersoy wrote: > Hi, > > On 10/02/2014 11:34 AM, Gilles wrote: >> Hello. >> >> On Thu, 02 Oct 2014 10:51:53 -0500, Ole Ersoy wrote: >>> Hello Luc, Gilles, and Benedikt, >>> >>> I'm here :). From my limited github experience, I do think most >>> contributors do their communic

Re: [GitHub] commons-math pull request: Updated the example documentation for t...

2014-10-02 Thread Ole Ersoy
Hi, On 10/02/2014 11:34 AM, Gilles wrote: Hello. On Thu, 02 Oct 2014 10:51:53 -0500, Ole Ersoy wrote: Hello Luc, Gilles, and Benedikt, I'm here :). From my limited github experience, I do think most contributors do their communication directly through github. "Commons" contributors? I sh

Re: [pool] time to cut 2.3

2014-10-02 Thread Jacopo Cappellato
On Oct 2, 2014, at 7:24 PM, Mark Thomas wrote: >> @@ -311,12 +310,8 @@ >> // Override getMessage to avoid creating objects and formatting >> // dates unless the log message will actually be used. >> @Override >> -public String getMessage() { >> -String

Re: [pool] time to cut 2.3

2014-10-02 Thread Mark Thomas
On 02/10/2014 18:00, Jacopo Cappellato wrote: > Thank you Phil and Gary for the responses. > > Phil, the approach you described makes sense to me and I agree: even if part > of the fields of DefaultPooledObject are not formally thread-safe, the state > transitions are preserved and this is the m

Re: [pool] time to cut 2.3

2014-10-02 Thread Jacopo Cappellato
Thank you Phil and Gary for the responses. Phil, the approach you described makes sense to me and I agree: even if part of the fields of DefaultPooledObject are not formally thread-safe, the state transitions are preserved and this is the most important function of this class. I understand that

Re: [GitHub] commons-math pull request: Updated the example documentation for t...

2014-10-02 Thread Gilles
Hello. On Thu, 02 Oct 2014 10:51:53 -0500, Ole Ersoy wrote: Hello Luc, Gilles, and Benedikt, I'm here :). From my limited github experience, I do think most contributors do their communication directly through github. "Commons" contributors? I've seen a lot of projects use issues for discu

Re: [GitHub] commons-math pull request: Updated the example documentation for t...

2014-10-02 Thread Ole Ersoy
Hello Luc, Gilles, and Benedikt, I'm here :). From my limited github experience, I do think most contributors do their communication directly through github. I've seen a lot of projects use issues for discussion. I personally like this, because it makes it easy to get up to speed on design

Re: Testing Apache Commons with JDK 8 EA builds

2014-10-02 Thread Rory O'Donnell Oracle, Dublin Ireland
Hi Benedict, Thanks for volunteering. It would be great to have a report once in a while, no set requirement. I am more interested in hearing from you when there are issues. Rgds,Rory On 02/10/2014 10:41, Benedikt Ritter wrote: Hi Rory, sorry for the late reply, I'm pretty busy at the momen

Re: svn commit: r1628921 - /commons/proper/lang/trunk/src/changes/changes.xml

2014-10-02 Thread Duncan Jones
Thanks Benedikt, I'd better poke my IDE with a sharp stick. The XML settings must be wrong. On 2 October 2014 11:07, wrote: > Author: britter > Date: Thu Oct 2 10:07:11 2014 > New Revision: 1628921 > > URL: http://svn.apache.org/r1628921 > Log: > Remove tab characters > > Modified: > common

[GitHub] commons-lang pull request: Fix test case. Internally the test case...

2014-10-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-lang/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [GitHub] commons-math pull request: Updated the example documentation for t...

2014-10-02 Thread Gilles
On Thu, 2 Oct 2014 11:48:19 +0200, Benedikt Ritter wrote: Hi Luc, this emails are outgenerated when a PR is created at github, so I wouldn't expect the contributor to be subscribed to the list. It's probably better to comment on the PR at github. Sorry to intervene; but why is it better to

Re: [GitHub] commons-math pull request: Updated the example documentation for t...

2014-10-02 Thread Benedikt Ritter
Hi Luc, this emails are outgenerated when a PR is created at github, so I wouldn't expect the contributor to be subscribed to the list. It's probably better to comment on the PR at github. Benedikt 2014-09-30 9:55 GMT+02:00 luc : > Hi Ole, > > Le 2014-09-30 02:09, oleersoy a écrit : > >> GitHub

Re: Testing Apache Commons with JDK 8 EA builds

2014-10-02 Thread Benedikt Ritter
Hi Rory, sorry for the late reply, I'm pretty busy at the moment. I'm fine if you list me in your wiki, although I currently don't know what my responsibilities will be. Do I need to write reports or something? You can add Apache Commons with me as contact to your wiki. Feel free to forward EA bu