Re: [VOTE] Release BCEL 6.0 based on RC2

2014-09-26 Thread Gary Gregory
On Fri, Sep 26, 2014 at 5:34 PM, Emmanuel Bourg wrote: > Le 26/09/2014 23:27, Gary Gregory a écrit : > > -1 (sorry). With the source zip, I ran 'mvn clean site' and got: > > But we are releasing a source zip to build a jar, not a site. > Seriously... that shouldn't block a release. > I see it di

Re: [VOTE] Release BCEL 6.0 based on RC2

2014-09-26 Thread Matt Benson
On Fri, Sep 26, 2014 at 4:12 PM, Emmanuel Bourg wrote: > Hi all, > > The second release candidate of BCEL is ready to pass under your scrutiny. > > Tag: > http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC2/ > (r1627879) > > Release notes: > http://people.apache.org/~ebourg/bcel

Re: [VOTE] Release Apache Commons Weaver 1.1 based on RC3

2014-09-26 Thread Matt Benson
On Wed, Sep 24, 2014 at 9:30 AM, Matt Benson wrote: > I would like to release the [weaver] component. > > Apache Commons Weaver 1.1 RC3 is available for review at: > https://dist.apache.org/repos/dist/dev/commons/weaver/ (r6646). > > Maven artifacts are at: > > https://repository.apache.org/con

Re: [VOTE] Release Apache Commons Weaver 1.1 based on RC3

2014-09-26 Thread Emmanuel Bourg
Le 24/09/2014 16:30, Matt Benson a écrit : > [X] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... Emmanuel Bourg signature.asc Description: OpenPGP digital signature

Re: [VOTE] Release BCEL 6.0 based on RC2

2014-09-26 Thread Emmanuel Bourg
Le 26/09/2014 23:27, Gary Gregory a écrit : > Also Cobertura blows up (i'm not sure Jacoco would fare better but it might > be worth a try): Cobertura works fine if executed with 'mvn cobertura:cobertura'. I don't know why it fails with 'mvn site'. I'll ensure the correct report is uploaded on th

Re: [VOTE] Release BCEL 6.0 based on RC2

2014-09-26 Thread Emmanuel Bourg
Le 26/09/2014 23:27, Gary Gregory a écrit : > -1 (sorry). With the source zip, I ran 'mvn clean site' and got: But we are releasing a source zip to build a jar, not a site. Seriously... that shouldn't block a release. Emmanuel Bourg --

Re: [VOTE] Release BCEL 6.0 based on RC2

2014-09-26 Thread Gary Gregory
Also, the checkstyle reports do not like the headers: Line does not match expected header line of ' * Unless required by applicable law or agreed to in writing, software'. There are many checkstyle issues reported but I am not sure that is any worse thank before. PMD has many: Avoid modifiers whi

Re: [VOTE] Release BCEL 6.0 based on RC2

2014-09-26 Thread Gary Gregory
-1 (sorry). With the source zip, I ran 'mvn clean site' and got: [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 03:33 min [INFO] Finished at: 201

[VOTE] Release BCEL 6.0 based on RC2

2014-09-26 Thread Emmanuel Bourg
Hi all, The second release candidate of BCEL is ready to pass under your scrutiny. Tag: http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC2/ (r1627879) Release notes: http://people.apache.org/~ebourg/bcel/RELEASE-NOTES.txt Distribution files: http://people.apache.org/~ebourg/b

Re: [VOTE] Release BCEL 6.0 based on RC1

2014-09-26 Thread Emmanuel Bourg
Thank you Gary, I confirm it works. Emmanuel Le 26/09/2014 21:27, Gary Gregory a écrit : > I see this in Log4j 2: > > > org.codehaus.mojo > findbugs-maven-plugin > ${findbugs.plugin.version} > > true > -Duser.language=en > No

Re: [LANG] Thoughts on LANG-1039

2014-09-26 Thread Duncan Jones
On 26 September 2014 14:53, Gary Gregory wrote: > Let's also think about what happens when you to an array into a Map. > > Does the fact that we are dealing with a reflection hashCode API mean it > should give the same key that would be used if you put the array in a map? > > Gary Hi Gary, I don'

Re: [VOTE] Release BCEL 6.0 based on RC1

2014-09-26 Thread Gary Gregory
I see this in Log4j 2: org.codehaus.mojo findbugs-maven-plugin ${findbugs.plugin.version} true -Duser.language=en Normal Default ${log4jParentDir}/findbugs-exclude-filter.xml Gary On Thu, Sep 25, 201

Re: [LANG] Thoughts on LANG-1039

2014-09-26 Thread Gary Gregory
Let's also think about what happens when you to an array into a Map. Does the fact that we are dealing with a reflection hashCode API mean it should give the same key that would be used if you put the array in a map? Gary On Fri, Sep 26, 2014 at 7:10 AM, Michael Pigott < mpigott.subscripti...@gm

Re: [LANG] Thoughts on LANG-1039

2014-09-26 Thread Michael Pigott
Hi Duncan, Does it make sense to create a method specifically for array types, which calls reflectonHashCode on each element to compute a final hash code? This would solve the poster's problem and avoid polluting reflectionHashCode with the behavior. Regards, Mike On Sep 26, 2014 6:32 AM, "Dun

[LANG] Thoughts on LANG-1039

2014-09-26 Thread Duncan Jones
Hi folks, I'd welcome someone else's viewpoint on LANG-1039. The question is: what should HashCodeBuilder.reflectionHashCode() do when given an array object as input. My argument is that the intended use of this method is for overriding Object.hashCode() and so it should never be the case than an