Re: [VOTE] Release Commons Lang 3.3.1 based on RC1

2014-03-17 Thread Matt Benson
On Sat, Mar 15, 2014 at 8:22 AM, Benedikt Ritter wrote: > Hi all, > > we have introduced a bug in release 3.3 when we fixed LANG-951 [1]. This > has been reported a few days ago and fixed by Duncan Jones in LANG-987 [2]. > Since there is no work around for this bug and sebb has also fixed quite a

Re: svn commit: r1578191 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java

2014-03-17 Thread Adrian Crum
Design philosophies like this should be documented in the project - that way there is no need to hash out the correct approach for every line of code. Everyone has different design philosophies, and in some cases there is no "right" or "wrong" philosophy. [In this thread, two fail-slow designs

Re: svn commit: r1578191 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java

2014-03-17 Thread Gary Gregory
I re-implemented the simplest behavior (back to what we had before): null -> IAE. Gary On Mon, Mar 17, 2014 at 2:31 PM, Emmanuel Bourg wrote: > Le 17/03/2014 19:21, Gary Gregory a écrit : > > > OK, then we are back to null -> exception. Check? > > I'd say default to the system encoding, like m

Re: svn commit: r1578191 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java

2014-03-17 Thread Emmanuel Bourg
Le 17/03/2014 19:21, Gary Gregory a écrit : > OK, then we are back to null -> exception. Check? I'd say default to the system encoding, like most methods of this kind. Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@

Re: svn commit: r1578191 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java

2014-03-17 Thread Gary Gregory
On Mon, Mar 17, 2014 at 1:48 PM, sebb wrote: > On 17 March 2014 17:26, Benedikt Ritter wrote: > > 2014-03-17 18:15 GMT+01:00 Gary Gregory : > > > >> On Mon, Mar 17, 2014 at 12:35 PM, Benedikt Ritter >> >wrote: > >> > >> > Hi all, > >> > > >> > is it sensible to fall back to UTF-8? Looks like an

Re: svn commit: r1578214 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/ArrayUtils.java

2014-03-17 Thread Gary Gregory
On Mon, Mar 17, 2014 at 1:19 PM, Benedikt Ritter wrote: > 2014-03-17 18:13 GMT+01:00 Gary Gregory : > > > On Mon, Mar 17, 2014 at 12:19 PM, Benedikt Ritter > >wrote: > > > > > Nice! > > > > > > > There are many more. I am hoping others will contribute. > > > > I'm planning to fix this after 3.3.

Re: svn commit: r1578191 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java

2014-03-17 Thread sebb
On 17 March 2014 17:26, Benedikt Ritter wrote: > 2014-03-17 18:15 GMT+01:00 Gary Gregory : > >> On Mon, Mar 17, 2014 at 12:35 PM, Benedikt Ritter > >wrote: >> >> > Hi all, >> > >> > is it sensible to fall back to UTF-8? Looks like an opportunity for bugs >> to >> > sneak in. I'd rather have: >> >

Re: svn commit: r1578191 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java

2014-03-17 Thread Benedikt Ritter
2014-03-17 18:15 GMT+01:00 Gary Gregory : > On Mon, Mar 17, 2014 at 12:35 PM, Benedikt Ritter >wrote: > > > Hi all, > > > > is it sensible to fall back to UTF-8? Looks like an opportunity for bugs > to > > sneak in. I'd rather have: > > > > public static CSVParser parse(final URL url, final Char

Re: svn commit: r1578214 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/ArrayUtils.java

2014-03-17 Thread Benedikt Ritter
2014-03-17 18:13 GMT+01:00 Gary Gregory : > On Mon, Mar 17, 2014 at 12:19 PM, Benedikt Ritter >wrote: > > > Nice! > > > > There are many more. I am hoping others will contribute. > I'm planning to fix this after 3.3.1. > > Gary > > > > > > > > 2014-03-17 3:44 GMT+01:00 : > > > > > Author: ggre

Re: svn commit: r1578191 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java

2014-03-17 Thread Gary Gregory
On Mon, Mar 17, 2014 at 12:35 PM, Benedikt Ritter wrote: > Hi all, > > is it sensible to fall back to UTF-8? Looks like an opportunity for bugs to > sneak in. I'd rather have: > > public static CSVParser parse(final URL url, final Charset charset, final > CSVFormat format) > > where none of the p

Re: svn commit: r1578214 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/ArrayUtils.java

2014-03-17 Thread Gary Gregory
On Mon, Mar 17, 2014 at 12:19 PM, Benedikt Ritter wrote: > Nice! > There are many more. I am hoping others will contribute. Gary > > > 2014-03-17 3:44 GMT+01:00 : > > > Author: ggregory > > Date: Mon Mar 17 02:44:58 2014 > > New Revision: 1578214 > > > > URL: http://svn.apache.org/r1578214 > >

Re: svn commit: r1578191 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java

2014-03-17 Thread Benedikt Ritter
Hi all, is it sensible to fall back to UTF-8? Looks like an opportunity for bugs to sneak in. I'd rather have: public static CSVParser parse(final URL url, final Charset charset, final CSVFormat format) where none of the params must be null, and: public static CSVParser parse(final URL url, f

Re: [VOTE] Release Commons Lang 3.3.1 based on RC1

2014-03-17 Thread Benedikt Ritter
My +1 FTR 2014-03-15 14:22 GMT+01:00 Benedikt Ritter : > Hi all, > > we have introduced a bug in release 3.3 when we fixed LANG-951 [1]. This > has been reported a few days ago and fixed by Duncan Jones in LANG-987 [2]. > Since there is no work around for this bug and sebb has also fixed quite a

Re: svn commit: r1578214 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/ArrayUtils.java

2014-03-17 Thread Benedikt Ritter
Nice! 2014-03-17 3:44 GMT+01:00 : > Author: ggregory > Date: Mon Mar 17 02:44:58 2014 > New Revision: 1578214 > > URL: http://svn.apache.org/r1578214 > Log: > Fix Javadoc 8 doclint issues. > > Modified: > > commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/ArrayUtils.java > > Modi

[imaging] Multipage in TIFF

2014-03-17 Thread Jesus Galindo
Hi, is there any way to generate multi page with TIFF format? I test with commons-imaging to generate TIFF and is this library is amazing, but I didn't see any documentation about to write TIFF multipage. Regards. --

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC3

2014-03-17 Thread Phil Steitz
On 3/15/14, 12:18 AM, Matt Benson wrote: > On Fri, Mar 14, 2014 at 9:28 PM, Niall Pemberton > wrote: > >> On Thu, Mar 13, 2014 at 10:25 PM, Matt Benson wrote: >> >>> On Wed, Mar 12, 2014 at 1:36 PM, Benedikt Ritter >>> wrote: >>> 2014-03-12 13:37 GMT+01:00 Gary Gregory : > [X] -1 I o

[ANNOUNCEMENT] Apache Commons Weaver 1.0 Released

2014-03-17 Thread Matt Benson
The Apache Commons team is pleased to announce the release of: Apache Commons Weaver 1.0 Apache Commons Weaver provides an easy way to enhance compiled Java classes by generating ("weaving") bytecode into those classes. Distribution packages can be downloaded from: https://commons.apache.org/pro