Re: svn commit: r1560382 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2014-01-23 Thread Gary Gregory
If the commit says "sort members" that's a good tip ;) Some IDEs like Eclipse can compare class structures not just files.  The grouping of setter and getters together is one subjective ordering as would be grouping together the read methods separately from the write methods. I have one or more

Re: svn commit: r1560382 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2014-01-23 Thread sebb
I think there is a big difference between creating a class with sorted methods, and retrospectively sorting methods in an existing class. That may improve the readibility of the class, or it may make the class much harder to read. For example with getters/setters: if these are kept together in pa

Re: svn commit: r1560382 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2014-01-23 Thread Paul Benedict
Yes, and Gary's argument is a very high priority driver behind my alphabetizing. I don't want to maintain groupings. I have concluded a long time ago that my time is wasted doing that stuff in code. On Thu, Jan 23, 2014 at 11:18 AM, Gary Gregory wrote: > Adopting a guideline like this is still a

Re: svn commit: r1560382 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2014-01-23 Thread Paul Benedict
FWIW, there's no solution that can make someone happy. Personally, I always alphabetize my methods because it's the most straightforward ordering -- no one has to guess why things are grouped together and sometimes groupings can get complex. I simply let people follow the javadocs/comments to make

Re: svn commit: r1560382 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2014-01-23 Thread Gary Gregory
Adopting a guideline like this is still a subjective arrangement. It's also takes time to maintain, not something I'm found of doing. To reach his own I suppose.  G Original message From: sebb Date:01/23/2014 09:15 (GMT-05:00) To: Commons Developers List Subject: Re: sv

Re: svn commit: r1560762 - /commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/StringUtilsTest.java

2014-01-23 Thread Benedikt Ritter
Sorry, I messed that one up. I wanted to call mvn clean test but instead committed with the some message as one before. Should be "Use annotation based testing for failure cases". Is there any way to modify the commit log? Benedikt 2014/1/23 > Author: britter > Date: Thu Jan 23 17:15:48 2014 >

Re: svn commit: r1560382 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVPrinter.java

2014-01-23 Thread sebb
On 23 January 2014 07:34, Emmanuel Bourg wrote: > Le 23/01/2014 08:03, Benedikt Ritter a écrit : >> I personally don't like alphabetically sorted classes. For example if a >> public method calls a private method, I like to have the private method >> beneath the public method that uses it. This way