[DBCP] Missing test cases - get rid of suite() and TestAll classes?

2010-01-16 Thread sebb
Just done a comparison of the tests run by Ant and Maven with the number of Test*.java files and found several discrepancies, including one test that was not being run by either: TestDelegatingCallableStatement (that was my fault - oops!). Seems to me that these discrepancies arose because of the

Re: [DBCP] Continuum failure - increase wait time?

2010-01-16 Thread sebb
On 16/01/2010, Phil Steitz wrote: > sebb wrote: > > On 15/01/2010, sebb wrote: > >> It's looking as if the problem with the Continuum test failures is > >> probably because the system is overloaded. > >> > >> Perhaps it does not make sense to have such a short wait time, i.e. > 100ms. >

Re: [DBCP] Continuum failure - increase wait time?

2010-01-16 Thread Phil Steitz
sebb wrote: > On 15/01/2010, sebb wrote: >> It's looking as if the problem with the Continuum test failures is >> probably because the system is overloaded. >> >> Perhaps it does not make sense to have such a short wait time, i.e. 100ms. >> >> Maybe better to increase the time to (say) 500ms, a

Re: [DBCP] Continuum failure - increase wait time?

2010-01-16 Thread sebb
On 15/01/2010, sebb wrote: > It's looking as if the problem with the Continuum test failures is > probably because the system is overloaded. > > Perhaps it does not make sense to have such a short wait time, i.e. 100ms. > > Maybe better to increase the time to (say) 500ms, and keep the hold >

Re: svn commit: r899929 - in /commons/proper/lang/trunk: src/main/java/org/apache/commons/lang3/ArrayUtils.java src/test/java/org/apache/commons/lang3/ArrayUtilsAddTest.java xdocs/changes.xml

2010-01-16 Thread sebb
On 16/01/2010, Henri Yandell wrote: > Alternatively... should add(null, null) simply return null? IMO it's a program bug to call it with both arguments null. The caller is going to have to check for null return in order to avoid an NPE; if they don't do so immediately the NPE could occur a long

Re: svn commit: r899929 - in /commons/proper/lang/trunk: src/main/java/org/apache/commons/lang3/ArrayUtils.java src/test/java/org/apache/commons/lang3/ArrayUtilsAddTest.java xdocs/changes.xml

2010-01-16 Thread Henri Yandell
Alternatively... should add(null, null) simply return null? Or throw NullPointerException? On Sat, Jan 16, 2010 at 4:39 AM, wrote: > Author: sebb > Date: Sat Jan 16 12:39:20 2010 > New Revision: 899929 > > URL: http://svn.apache.org/viewvc?rev=899929&view=rev > Log: > LANG-571 ArrayUtils.add(T[

Re: svn commit: r899895 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/Range.java

2010-01-16 Thread Henri Yandell
On Sat, Jan 16, 2010 at 4:08 AM, sebb wrote: > On 16/01/2010, bay...@apache.org wrote: >> Author: bayard >>  Date: Sat Jan 16 07:58:11 2010 >>  New Revision: 899895 >> >>  URL: http://svn.apache.org/viewvc?rev=899895&view=rev >>  Log: >>  Adding String lazy caching >> >>  Modified: >>     >> com

[continuum] BUILD SUCCESSFUL: Commons - Commons DBCP -

2010-01-16 Thread contin...@vmbuild.apache.org
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=270996&projectId=22 Build statistics: State: Ok Previous State: Failed Started at: Sat 16 Jan 2010 09:02:52 -0800 Finished at: Sat 16 Jan 2010 09:04:53 -0800 Total time: 2m 0s Build Trigger: Schedule Buil

[continuum] BUILD FAILURE: Commons - Commons Pool - Try debug build

2010-01-16 Thread contin...@vmbuild.apache.org
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=270966&projectId=116 Build statistics: State: Failed Previous State: Ok Started at: Sat 16 Jan 2010 07:47:09 -0800 Finished at: Sat 16 Jan 2010 07:50:03 -0800 Total time: 2m 53s Build Trigger: Forced Buil

Re: [pool] okay to close POOL-119?

2010-01-16 Thread Phil Steitz
Christoph Kutzinski wrote: > Hi, > > https://issues.apache.org/jira/browse/POOL-119 "GenericObjectPool: > Provide option to create new objects serial" > > I had created this issue long ago, but as I have currently no interest > in commons-pool anymore and no one else seems to care about the issue

[continuum] BUILD SUCCESSFUL: Commons - Commons Pool - Try debug build

2010-01-16 Thread contin...@vmbuild.apache.org
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=270893&projectId=116 Build statistics: State: Ok Previous State: Failed Started at: Sat 16 Jan 2010 05:31:25 -0800 Finished at: Sat 16 Jan 2010 05:33:49 -0800 Total time: 2m 24s Build Trigger: Schedule Bu

Re: svn commit: r899895 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/Range.java

2010-01-16 Thread sebb
On 16/01/2010, bay...@apache.org wrote: > Author: bayard > Date: Sat Jan 16 07:58:11 2010 > New Revision: 899895 > > URL: http://svn.apache.org/viewvc?rev=899895&view=rev > Log: > Adding String lazy caching > > Modified: > > commons/proper/lang/trunk/src/main/java/org/apache/commons/lan

[pool] okay to close POOL-119?

2010-01-16 Thread Christoph Kutzinski
Hi, https://issues.apache.org/jira/browse/POOL-119 "GenericObjectPool: Provide option to create new objects serial" I had created this issue long ago, but as I have currently no interest in commons-pool anymore and no one else seems to care about the issue I describe there: Is it okay POOL-1

[continuum] BUILD FAILURE: Commons - Commons Pool - Try debug build

2010-01-16 Thread contin...@vmbuild.apache.org
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=270838&projectId=116 Build statistics: State: Failed Previous State: Ok Started at: Sat 16 Jan 2010 03:04:24 -0800 Finished at: Sat 16 Jan 2010 03:08:17 -0800 Total time: 3m 53s Build Trigger: Schedule Bu

[continuum] BUILD SUCCESSFUL: Commons - Commons Pool - Try debug build

2010-01-16 Thread contin...@vmbuild.apache.org
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=270764&projectId=116 Build statistics: State: Ok Previous State: Failed Started at: Sat 16 Jan 2010 00:50:11 -0800 Finished at: Sat 16 Jan 2010 00:52:54 -0800 Total time: 2m 42s Build Trigger: Schedule Bu