Re: [COMPRESS] Archive Stream refactoring

2009-03-29 Thread Christian Grobmeier
>> We could also add some new methods with partial implementations, for example >> putArchiveEntry(File) >> extractFile(File basedir, Entry) > > If this is a common usecase, yes.  The only real user of a simial API > I know is Ant and here those methods wouldn't help since they don't > provide a wa

Re: [COMPRESS] Changeset ideas

2009-03-29 Thread Christian Grobmeier
Hi, > The current ChangeSet API allows for: > + deletion of entries by name > + addition of entries by ArchiveEntry and InputStream. > > This is fine as far as it goes, but I think it would be useful to add: > + addition of entries by File > + replacement of an existing named entry by File or Entr

Re: [COMPRESS] Archive Stream refactoring

2009-03-29 Thread Stefan Bodewig
On 2009-03-29, sebb wrote: > The existing ArchiveInputStream and ArchiveOutputStream abstract > classes are quite minimal. Seems to me that there is quite a lot of > common code that they could provide. > For example, if the Stream was stored as a protected variable, then > they could provide ge

Re: [COMPRESS] Changeset ideas

2009-03-29 Thread Stefan Bodewig
your API suggesteions sound useful. On 2009-03-30, sebb wrote: > On 29/03/2009, sebb wrote: >> On 29/03/2009, sebb wrote: >>> The current ChangeSet API allows for: deletion of entries by name > The same method call is currently used for both deleting a single > file, and for deleting a d

Re: svn commit: r759472 - in /commons/proper/compress/trunk/src/site: site.xml xdoc/examples.xml xdoc/index.xml xdoc/zip.xml

2009-03-29 Thread Stefan Bodewig
On 2009-03-28, sebb wrote: > On 28/03/2009, Stefan Bodewig wrote: >> On 2009-03-28, sebb wrote: >>> I thought the idea was that the ArchiveInputStreams would not allow >>> one to read past the end of the entry, so one can just read until >>> read() returns -1? >> I don't think AR is the only

Re: [COMPRESS] Changeset ideas

2009-03-29 Thread sebb
On 29/03/2009, sebb wrote: > On 29/03/2009, sebb wrote: > > The current ChangeSet API allows for: > > + deletion of entries by name The same method call is currently used for both deleting a single file, and for deleting a directory tree. If the string matches a file, it is deleted, but if it

Re: [Configuration] Dependency on VFS

2009-03-29 Thread sebb
On 29/03/2009, Ralph Goers wrote: > > On Mar 29, 2009, at 9:08 AM, sebb wrote: > > > > On 29/03/2009, Ralph Goers wrote: > > > > > > > > > > > > > > > > > > > > > > > No, you have to use the profile. There are a couple of system properties > > > that get set in addition to the url and additional

Re: [Configuration] Dependency on VFS

2009-03-29 Thread Ralph Goers
On Mar 29, 2009, at 9:08 AM, sebb wrote: On 29/03/2009, Ralph Goers wrote: No, you have to use the profile. There are a couple of system properties that get set in addition to the url and additional dependencies are added. For example, jackrabbit is required for the WebDAV test to run

Re: [COMPRESS] Changeset ideas

2009-03-29 Thread sebb
On 29/03/2009, sebb wrote: > The current ChangeSet API allows for: > + deletion of entries by name > + addition of entries by ArchiveEntry and InputStream. Forgot about "Move", which is not yet implemented. I think that should be called "Rename", unless it really means to move the entry elsewh

Re: [Configuration] Dependency on VFS

2009-03-29 Thread sebb
On 29/03/2009, Ralph Goers wrote: > > On Mar 29, 2009, at 5:03 AM, sebb wrote: > > > > > > > > > > > > > Can one also run the tests by adding > > > > > -Dtest.webdav.uri=webdav://admin:ad...@192.168.10.133:7402/vfstest/test-data > > > > etc. to the command-line? That's perhaps simpler for one-off

Re: [Configuration] Dependency on VFS

2009-03-29 Thread Ralph Goers
On Mar 29, 2009, at 5:03 AM, sebb wrote: Can one also run the tests by adding -Dtest.webdav.uri=webdav://admin:ad...@192.168.10.133:7402/vfstest/ test-data etc. to the command-line? That's perhaps simpler for one-off tests. No, you have to use the profile. There are a couple of system

[g...@vmgump]: Project commons-compress-test (in module apache-commons) failed

2009-03-29 Thread commons-compress development
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-compress-test has an issue affecting its community integration. Th

[COMPRESS] Archive Stream refactoring

2009-03-29 Thread sebb
The existing ArchiveInputStream and ArchiveOutputStream abstract classes are quite minimal. Seems to me that there is quite a lot of common code that they could provide. For example, if the Stream was stored as a protected variable, then they could provide generic implementations for many of the s

[COMPRESS] Changeset ideas

2009-03-29 Thread sebb
The current ChangeSet API allows for: + deletion of entries by name + addition of entries by ArchiveEntry and InputStream. This is fine as far as it goes, but I think it would be useful to add: + addition of entries by File + replacement of an existing named entry by File or Entry+InputStream It

Re: [Configuration] Dependency on VFS

2009-03-29 Thread sebb
On 29/03/2009, Ralph Goers wrote: > I need to document this. When you run all the tests > TestWebdavConfigurationBuilder is skipped because it is really a functional > test - it requires a WebDAV server to be available. To run the test you need > to add something like > > > webdav >

[g...@vmgump]: Project commons-configuration (in module apache-commons) failed

2009-03-29 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-configuration has an issue affecting its community integration. Th