[dbutils] Questions about a few of bugs

2009-02-09 Thread Dan Fabulich
I had some questions about a few remaining bugs... maybe somebody here can help... 1) OptimalBeanListHandler http://issues.apache.org/jira/browse/DBUTILS-37 This bug provides a patch that considerably improves the performance of BeanListHandler. However, Julien correctly points out that: W

Re: [VOTE] CLI 1.2 release (RC2)

2009-02-09 Thread Henri Yandell
If I rollback the change from CLI-162, and comment out the testInfiniteLoop; your new test also infinite loops. So CLI-162 is a sign that something has broken in that class since 1.1, rather than it being an existing issue in 1.1. Rolling back each commit on HelpFormatter, the issue appears to hav

Re: [dbutils] QueryRunner.fillStatement and the null problem (long)

2009-02-09 Thread Dan Fabulich
OK, I've checked in a fix for the null problem (and the five bugs surrounding it) in revision 742865. Code review here is welcome. http://svn.apache.org/viewvc?view=rev&revision=742865 The code passes against Derby, but, as I mentioned earlier, I don't have an Oracle test instance to run ag

Re: [VOTE] CLI 1.2 release (RC2)

2009-02-09 Thread Henri Yandell
Thanks for the update. It's invoked when I run mvn package: Running org.apache.commons.cli.bug.BugCLI162Test Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.013 sec <<< FAILURE! Hen On Mon, Feb 9, 2009 at 8:46 PM, Gary Gregory wrote: > Hen: > > Ok, I've updated the class BugC

RE: [VOTE] CLI 1.2 release (RC2)

2009-02-09 Thread Gary Gregory
Hen: Ok, I've updated the class BugCLI162Test in SVN with a failing test. Note that BugCLI162Test is not invoked during a Maven build. Is this an omission? How about an AllTests class for the "bug" package? Thanks, Gary -Original Message- From: Gary Gregory [mailto:ggreg...@seagullsoft

RE: [VOTE] CLI 1.2 release (RC2)

2009-02-09 Thread Gary Gregory
I'll extract a unit test from our code and post a new ticket. Gary -Original Message- From: Henri Yandell [mailto:flame...@gmail.com] Sent: Monday, February 09, 2009 7:10 PM To: Commons Developers List Subject: Re: [VOTE] CLI 1.2 release (RC2) I think it's a showstopper - that was a fix

Re: [VOTE] CLI 1.2 release (RC2)

2009-02-09 Thread Henri Yandell
I think it's a showstopper - that was a fix due to infinite looping causing an OOM. Sounds like you have a test case that isn't covered by the current tests. Hen On Mon, Feb 9, 2009 at 1:33 PM, Gary Gregory wrote: > Hello Hen: > > I've encountered a backwards compatibility issue in our applicati

Re: [VOTE] CLI 1.2 release (RC2)

2009-02-09 Thread Paul Benedict
If Gary's issue isn't deemed a showstopper, this is my +1 On Mon, Feb 9, 2009 at 3:33 PM, Gary Gregory wrote: > Hello Hen: > > I've encountered a backwards compatibility issue in our application unit test > suite related to [CLI-162]. > > With version 1.1, I can print call HelpFormatter#printHel

Re: [dbutils] QueryRunner.fillStatement and the null problem (long)

2009-02-09 Thread sebb
On 09/02/2009, Dan Fabulich wrote: > Liam Coughlin wrote: > > > > b) Yes it will have a thread safety issue -- you'll need to synchronize on > > something when setting the pmdKnownBroken variable. > > > > When setting? Or when reading? Remember, once pmdKnownBroken is true, it > will never agai

Re: [dbutils] QueryRunner.fillStatement and the null problem (long)

2009-02-09 Thread Dan Fabulich
Liam Coughlin wrote: b) Yes it will have a thread safety issue -- you'll need to synchronize on something when setting the pmdKnownBroken variable. When setting? Or when reading? Remember, once pmdKnownBroken is true, it will never again be false, so there's no risk that one thread will try

RE: [VOTE] CLI 1.2 release (RC2)

2009-02-09 Thread Gary Gregory
Hello Hen: I've encountered a backwards compatibility issue in our application unit test suite related to [CLI-162]. With version 1.1, I can print call HelpFormatter#printHelp(String,Options) without any problems without our options. When I replace 1.1 with 1.2 I get: Exception in thread "main

Re: [VOTE] CLI 1.2 release (RC2)

2009-02-09 Thread Oliver Heger
+1 Oliver Note: The link to the binaries is wrong. Replace RC1 by RC2. Henri Yandell schrieb: Apologies for the revote. I've added a note to the release page to check the NOTICE file's copyright year. There should be no difference between the two other than the RC1->RC2 in the pom and the upd

Re: [dbutils] QueryRunner.fillStatement and the null problem (long)

2009-02-09 Thread Liam Coughlin
snip > >int sqlType = Types.VARCHAR; >if (!pmdKnownBroken) { >try { >sqlType = stmt.getParameterMetaData().getParameterType(i+1); >} catch (Exception e) { pmdKnownBroken = true; } >} >stmt.setNull(i + 1, sqlType); > > Possibly we'd add a new argument to

[dbutils] QueryRunner.fillStatement and the null problem (long)

2009-02-09 Thread Dan Fabulich
This email is long, so here's the executive summary: Summary: The Oracle JDBC driver is broken in ways that will require some Oracle-specific workarounds. I think I have a good workaround in mind, but I don't actually have an Oracle instance available to test. Can somebody tell me if I'm do

Re: [pipeline] documentation patch submitted

2009-02-09 Thread Ken Tanaka
Rahul Akolkar wrote: On Thu, Feb 5, 2009 at 1:41 PM, Ken Tanaka wrote: I submitted a small documentation fix for the pipeline_basics tutorial. ... This is issue SANDBOX-278 Applied patch and republished site. -Rahul Thank you. Now people can cut and paste from the w

Re: [io] Version for Java 1.4

2009-02-09 Thread Jukka Zitting
Hi, On Sun, Feb 8, 2009 at 8:54 PM, Henri Yandell wrote: > On Sun, Feb 8, 2009 at 5:04 AM, Niall Pemberton >> I think the new Java5 stuff in trunk should be released as IO 2.0 - so >> we could release a IO 1.5 version that is for JDK 1.4. Having said >> that JDK 1.4 is so old now I don't really t

Re: [math] When are OpenIntToDoubleHashMap instances equal? WAS Re: svn commit: r742257 - in /commons/proper/math/trunk/src: java/org/apache/commons/math/linear/ java/org/apache/commons/math/util/ t

2009-02-09 Thread Bill Barker
Ok, sort of letting eclipse take over. More comments inline. "Phil Steitz" wrote in message news:49901038.2070...@gmail.com... > billbar...@apache.org wrote: > > Do we need this? >> +if (mask != other.mask) >> +return false; >> . as the code stands now, unnecessary. The va

[math] When are OpenIntToDoubleHashMap instances equal? WAS Re: svn commit: r742257 - in /commons/proper/math/trunk/src: java/org/apache/commons/math/linear/ java/org/apache/commons/math/util/ test/

2009-02-09 Thread Phil Steitz
billbar...@apache.org wrote: Do we need this? +if (mask != other.mask) +return false; ... Or this? +if (!Arrays.equals(states, other.states)){ It would seem reasonable to me that two OpenIntToDoubleHashMaps would be equal iff they contain they contain the s

Re: New committer: Paul Benedict

2009-02-09 Thread Jukka Zitting
Hi, On Mon, Feb 9, 2009 at 3:48 AM, Henri Yandell wrote: > Welcoming Paul as a new committer to Commons. Realizing that we don't > announce this very publicly usually. > > Mark Thomas became a committer at the start of January and Ralph Goers > became a committer back in November. Dan Fabulich be

Re: New committer: Paul Benedict

2009-02-09 Thread Antonio Petrelli
2009/2/9 Henri Yandell : > Welcoming Paul as a new committer to Commons. Congrats Paul! Antonio - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org